awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-09-22 13:39:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address reviews

Browse Source
This commit is contained in:
x032205
2025-08-11 15:15:48 -07:00
parent d1e8ae3c98
commit ce8653e908
3 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
backend/src/ee/routes/v1/access-approval-policy-router.ts
View File

@@ -13,9 +13,10 @@ import { AuthMode } from "@app/services/auth/auth-type";
const maxTimePeriodSchema = z const maxTimePeriodSchema = z
.string() .string()
.trim() .trim()
.optional() .nullish()
.transform((val, ctx) => { .transform((val, ctx) => {
if (val === undefined) return undefined; if (val === undefined) return undefined;
if (!val || val === "permanent") return null;
const parsedMs = ms(val); const parsedMs = ms(val);
if (typeof parsedMs !== "number" || parsedMs <= 0) { if (typeof parsedMs !== "number" || parsedMs <= 0) {

4
backend/src/ee/services/access-approval-policy/access-approval-policy-types.ts
View File

@@ -41,7 +41,7 @@ export type TCreateAccessApprovalPolicy = {
enforcementLevel: EnforcementLevel; enforcementLevel: EnforcementLevel;
allowedSelfApprovals: boolean; allowedSelfApprovals: boolean;
approvalsRequired?: { numberOfApprovals: number; stepNumber: number }[]; approvalsRequired?: { numberOfApprovals: number; stepNumber: number }[];
maxTimePeriod?: string; maxTimePeriod?: string | null;
} & Omit<TProjectPermission, "projectId">; } & Omit<TProjectPermission, "projectId">;
export type TUpdateAccessApprovalPolicy = { export type TUpdateAccessApprovalPolicy = {
@@ -61,7 +61,7 @@ export type TUpdateAccessApprovalPolicy = {
allowedSelfApprovals: boolean; allowedSelfApprovals: boolean;
approvalsRequired?: { numberOfApprovals: number; stepNumber: number }[]; approvalsRequired?: { numberOfApprovals: number; stepNumber: number }[];
environments?: string[]; environments?: string[];
maxTimePeriod?: string; maxTimePeriod?: string | null;
} & Omit<TProjectPermission, "projectId">; } & Omit<TProjectPermission, "projectId">;
export type TDeleteAccessApprovalPolicy = { export type TDeleteAccessApprovalPolicy = {

6
frontend/src/hooks/api/accessApproval/types.ts
View File

@@ -18,7 +18,7 @@ export type TAccessApprovalPolicy = {
approvers?: Approver[]; approvers?: Approver[];
bypassers?: Bypasser[]; bypassers?: Bypasser[];
allowedSelfApprovals: boolean; allowedSelfApprovals: boolean;
maxTimePeriod?: string; maxTimePeriod?: string | null;
}; };
export enum ApproverType { export enum ApproverType {
@@ -175,7 +175,7 @@ export type TCreateAccessPolicyDTO = {
enforcementLevel?: EnforcementLevel; enforcementLevel?: EnforcementLevel;
allowedSelfApprovals: boolean; allowedSelfApprovals: boolean;
approvalsRequired?: { numberOfApprovals: number; stepNumber: number }[]; approvalsRequired?: { numberOfApprovals: number; stepNumber: number }[];
maxTimePeriod?: string; maxTimePeriod?: string | null;
}; };
export type TUpdateAccessPolicyDTO = { export type TUpdateAccessPolicyDTO = {
@@ -191,7 +191,7 @@ export type TUpdateAccessPolicyDTO = {
// for invalidating list // for invalidating list
projectSlug: string; projectSlug: string;
approvalsRequired?: { numberOfApprovals: number; stepNumber: number }[]; approvalsRequired?: { numberOfApprovals: number; stepNumber: number }[];
maxTimePeriod?: string; maxTimePeriod?: string | null;
}; };
export type TDeleteSecretPolicyDTO = { export type TDeleteSecretPolicyDTO = {