Address PR comments for Azure Client Secret Rotation

backend/src/ee/services/secret-rotation-v2/azure-client-secret/azure-client-secret-rotation-fns.ts

@@ -153,12 +153,8 @@ export const azureClientSecretRotationFactory: TRotationFactory<
    * Maps the generated credentials into the secret payload format.
    */
   const getSecretsPayload: TRotationFactoryGetSecretsPayload<TAzureClientSecretRotationGeneratedCredentials> = ({
-    clientSecret,
+    clientSecret
-    clientId
+  }) => [{ key: secretsMapping.clientSecret, value: clientSecret }];
-  }) => [
-    { key: secretsMapping.clientSecret, value: clientSecret },
-    { key: secretsMapping.clientId, value: clientId }
-  ];
 
   return {
     issueCredentials,

backend/src/services/app-connection/azure-client-secrets/azure-client-secrets-connection-fns.ts

@@ -31,8 +31,6 @@ export const getAzureClientSecretsConnectionListItem = () => {
   };
 };
 
-const EXPIRATION_TIME = 300000;
-
 export const getAzureConnectionAccessToken = async (
   connectionId: string,
   appConnectionDAL: Pick<TAppConnectionDALFactory, "findById" | "updateById">,
@@ -63,14 +61,9 @@ export const getAzureConnectionAccessToken = async (
     encryptedCredentials: appConnection.encryptedCredentials
   })) as TAzureClientSecretsConnectionCredentials;
 
-  const { expiresAt, refreshToken } = credentials;
+  const { refreshToken } = credentials;
   const currentTime = Date.now();
 
-  // get new token if expired or less than 5 minutes until expiry
-  if (currentTime < expiresAt - EXPIRATION_TIME) {
-    return credentials.accessToken;
-  }
-
   const { data } = await request.post<ExchangeCodeAzureResponse>(
     IntegrationUrls.AZURE_TOKEN_URL.replace("common", credentials.tenantId || "common"),
     new URLSearchParams({

docs/integrations/app-connections/azure-client-secrets.mdx

@@ -36,13 +36,19 @@ Infisical currently only supports one method for connecting to Azure, which is O
 
       #### Azure Client Secrets permissions
     
-      Set the API permissions of the Azure application to include the following Azure Client Secrets permissions: 
+      Set the API permissions of the Azure application to include the following permissions: 
         - Microsoft Graph
           - `Application.ReadWrite.All`
+          - `Application.ReadWrite.OwnedBy`
+          - `Application.ReadWrite.All` (Delegated)
+          - `Directory.ReadWrite.All` (Delegated)
+          - `User.Read` (Delegated)
         - Azure App Configuration
-          - `KeyValue.Delete`
+          - `KeyValue.Delete` (Delegated)
-          - `KeyValue.Read`
+          - `KeyValue.Read` (Delegated)
-          - `KeyValue.Write`
+          - `KeyValue.Write` (Delegated)
+        - Access Key Vault
+          - `user_impersonation` (Delegated)
 
       ![Azure client secrets](/images/integrations/azure-client-secrets/app-api-permissions.png)
 

frontend/src/components/secret-rotations-v2/ViewSecretRotationV2GeneratedCredentials/ViewAzureClientSecretRotationGeneratedCredentials.tsx

@@ -19,7 +19,7 @@ export const ViewAzureClientSecretRotationGeneratedCredentials = ({
     <ViewRotationGeneratedCredentialsDisplay
       activeCredentials={
         <>
-          <CredentialDisplay label="Client ID">{activeCredentials?.clientId}</CredentialDisplay>
+          <CredentialDisplay label="Secret ID">{activeCredentials?.clientId}</CredentialDisplay>
           <CredentialDisplay isSensitive label="Client Secret">
             {activeCredentials?.clientSecret}
           </CredentialDisplay>
@@ -27,7 +27,7 @@ export const ViewAzureClientSecretRotationGeneratedCredentials = ({
       }
       inactiveCredentials={
         <>
-          <CredentialDisplay label="Client ID">{inactiveCredentials?.clientId}</CredentialDisplay>
+          <CredentialDisplay label="Secret ID">{inactiveCredentials?.clientId}</CredentialDisplay>
           <CredentialDisplay isSensitive label="Client Secret">
             {inactiveCredentials?.clientSecret}
           </CredentialDisplay>

frontend/src/components/secret-rotations-v2/forms/SecretRotationV2ParametersFields/AzureClientSecretRotationParametersFields.tsx

@@ -38,8 +38,11 @@ export const AzureClientSecretRotationParametersFields = () => {
               content={
                 <>
                   Ensure that your connection has the{" "}
-                  <span className="font-semibold">Application.ReadWrite.All</span> permission and
+                  <span className="font-semibold">
-                  the application exists in Azure.
+                    Application.ReadWrite.All, Directory.ReadWrite.All,
+                    Application.ReadWrite.OwnedBy, user_impersonation and User.Read
+                  </span>{" "}
+                  permissions and the application exists in Azure.
                 </>
               }
             >

frontend/src/components/secret-rotations-v2/forms/SecretRotationV2SecretsMappingFields/AzureClientSecretRotationSecretsMappingFields.tsx

@@ -16,24 +16,6 @@ export const AzureClientSecretRotationSecretsMappingFields = () => {
   const { rotationOption } = useSecretRotationV2Option(SecretRotation.AzureClientSecret);
 
   const items = [
-    {
-      name: "Client ID",
-      input: (
-        <Controller
-          render={({ field: { value, onChange }, fieldState: { error } }) => (
-            <FormControl isError={Boolean(error)} errorText={error?.message}>
-              <Input
-                value={value}
-                onChange={onChange}
-                placeholder={rotationOption?.template.secretsMapping.clientId}
-              />
-            </FormControl>
-          )}
-          control={control}
-          name="secretsMapping.clientId"
-        />
-      )
-    },
     {
       name: "Client Secret",
       input: (