From cfa8770bdc19e7ca071eaab31232c243d04f9687 Mon Sep 17 00:00:00 2001
From: Sheen Capadngan <sheensantoscapadngan@gmail.com>
Date: Tue, 5 Nov 2024 21:57:40 +0800
Subject: [PATCH] misc: addressed issue

---
 .../secret-rotation-queue-types.ts                  |  2 +-
 .../secret-rotation-queue/secret-rotation-queue.ts  | 13 +++++++------
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/backend/src/ee/services/secret-rotation/secret-rotation-queue/secret-rotation-queue-types.ts b/backend/src/ee/services/secret-rotation/secret-rotation-queue/secret-rotation-queue-types.ts
index 1cbcbb1ab..e0d4c1876 100644
--- a/backend/src/ee/services/secret-rotation/secret-rotation-queue/secret-rotation-queue-types.ts
+++ b/backend/src/ee/services/secret-rotation/secret-rotation-queue/secret-rotation-queue-types.ts
@@ -24,5 +24,5 @@ export type TSecretRotationDbFn = {
   query: string;
   variables: unknown[];
   ca?: string;
-  options: Record<string, unknown>;
+  options?: Record<string, unknown>;
 };
diff --git a/backend/src/ee/services/secret-rotation/secret-rotation-queue/secret-rotation-queue.ts b/backend/src/ee/services/secret-rotation/secret-rotation-queue/secret-rotation-queue.ts
index e9c4ecbd9..d21f7674b 100644
--- a/backend/src/ee/services/secret-rotation/secret-rotation-queue/secret-rotation-queue.ts
+++ b/backend/src/ee/services/secret-rotation/secret-rotation-queue/secret-rotation-queue.ts
@@ -94,7 +94,9 @@ export const secretRotationQueueFactory = ({
           // on prod it this will be in days, in development this will be second
           every: appCfg.NODE_ENV === "development" ? secondsToMillis(interval) : daysToMillisecond(interval),
           immediately: true
-        }
+        },
+        removeOnComplete: true,
+        removeOnFail: true
       }
     );
   };
@@ -173,14 +175,13 @@ export const secretRotationQueueFactory = ({
         newCredential.internal.rotated_password = alphaNumericNanoId(32);
         const { admin_username: username, admin_password: password, host, database, port, ca } = newCredential.inputs;
 
-        const options = (
+        const options =
           provider.template.client === TDbProviderClients.MsSqlServer
-            ? {
+            ? ({
                 encrypt: true,
                 cryptoCredentialsDetails: ca ? { ca } : {}
-              }
-            : {}
-        ) as Record<string, unknown>;
+              } as Record<string, unknown>)
+            : undefined;
 
         const dbFunctionArg = {
           username,