From cffcb28bc9bfdc204288d6a649e6bdf306e1b28c Mon Sep 17 00:00:00 2001 From: = Date: Wed, 29 Jan 2025 17:50:02 +0530 Subject: [PATCH] feat: removed secret path check in glob --- backend/src/ee/services/permission/project-permission.ts | 5 +---- .../components/ProjectRoleModifySection.utils.tsx | 4 +++- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/backend/src/ee/services/permission/project-permission.ts b/backend/src/ee/services/permission/project-permission.ts index 6e337e4d8..e9ba49127 100644 --- a/backend/src/ee/services/permission/project-permission.ts +++ b/backend/src/ee/services/permission/project-permission.ts @@ -180,10 +180,7 @@ const SECRET_PATH_PERMISSION_OPERATOR_SCHEMA = z.union([ (val) => val.every((el) => el.startsWith("/")), SECRET_PATH_MISSING_SLASH_ERR_MSG ), - [PermissionConditionOperators.$GLOB]: PermissionConditionSchema[PermissionConditionOperators.$GLOB].refine( - (val) => val.startsWith("/"), - SECRET_PATH_MISSING_SLASH_ERR_MSG - ) + [PermissionConditionOperators.$GLOB]: PermissionConditionSchema[PermissionConditionOperators.$GLOB] }) .partial() ]); diff --git a/frontend/src/pages/project/RoleDetailsBySlugPage/components/ProjectRoleModifySection.utils.tsx b/frontend/src/pages/project/RoleDetailsBySlugPage/components/ProjectRoleModifySection.utils.tsx index 182f6cb52..dc850581f 100644 --- a/frontend/src/pages/project/RoleDetailsBySlugPage/components/ProjectRoleModifySection.utils.tsx +++ b/frontend/src/pages/project/RoleDetailsBySlugPage/components/ProjectRoleModifySection.utils.tsx @@ -84,7 +84,9 @@ const ConditionSchema = z .refine( (val) => val - .filter((el) => el.lhs === "secretPath") + .filter( + (el) => el.lhs === "secretPath" && el.operator !== PermissionConditionOperators.$GLOB + ) .every((el) => el.operator === PermissionConditionOperators.$IN ? el.rhs.split(",").every((i) => i.trim().startsWith("/"))