From d1ad605ac4a3b0acbb3f37696c7bf65927515b81 Mon Sep 17 00:00:00 2001
From: Sheen Capadngan <sheensantoscapadngan@gmail.com>
Date: Wed, 5 Mar 2025 21:19:41 +0800
Subject: [PATCH] misc: address nit

---
 .../src/ee/routes/v1/secret-approval-request-router.ts    | 2 +-
 backend/src/ee/services/audit-log/audit-log-types.ts      | 8 ++++----
 frontend/src/hooks/api/auditLogs/constants.tsx            | 2 +-
 frontend/src/hooks/api/auditLogs/enums.tsx                | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/backend/src/ee/routes/v1/secret-approval-request-router.ts b/backend/src/ee/routes/v1/secret-approval-request-router.ts
index 2c503515c..653d04d4f 100644
--- a/backend/src/ee/routes/v1/secret-approval-request-router.ts
+++ b/backend/src/ee/routes/v1/secret-approval-request-router.ts
@@ -185,7 +185,7 @@ export const registerSecretApprovalRequestRouter = async (server: FastifyZodProv
         orgId: req.permission.orgId,
         projectId: review.projectId,
         event: {
-          type: EventType.SECRET_APPROVAL_REQUEST_REVIEWED,
+          type: EventType.SECRET_APPROVAL_REQUEST_REVIEW,
           metadata: {
             secretApprovalRequestId: review.requestId,
             reviewedBy: review.reviewerUserId,
diff --git a/backend/src/ee/services/audit-log/audit-log-types.ts b/backend/src/ee/services/audit-log/audit-log-types.ts
index 3e35c16f8..a8f96bb73 100644
--- a/backend/src/ee/services/audit-log/audit-log-types.ts
+++ b/backend/src/ee/services/audit-log/audit-log-types.ts
@@ -166,7 +166,7 @@ export enum EventType {
   SECRET_APPROVAL_REQUEST = "secret-approval-request",
   SECRET_APPROVAL_CLOSED = "secret-approval-closed",
   SECRET_APPROVAL_REOPENED = "secret-approval-reopened",
-  SECRET_APPROVAL_REQUEST_REVIEWED = "secret-approval-request-reviewed",
+  SECRET_APPROVAL_REQUEST_REVIEW = "secret-approval-request-review",
   SIGN_SSH_KEY = "sign-ssh-key",
   ISSUE_SSH_CREDS = "issue-ssh-creds",
   CREATE_SSH_CA = "create-ssh-certificate-authority",
@@ -1316,8 +1316,8 @@ interface SecretApprovalRequest {
   };
 }
 
-interface SecretApprovalRequestReviewed {
-  type: EventType.SECRET_APPROVAL_REQUEST_REVIEWED;
+interface SecretApprovalRequestReview {
+  type: EventType.SECRET_APPROVAL_REQUEST_REVIEW;
   metadata: {
     secretApprovalRequestId: string;
     reviewedBy: string;
@@ -2495,4 +2495,4 @@ export type Event =
   | KmipOperationLocateEvent
   | KmipOperationRegisterEvent
   | CreateSecretRequestEvent
-  | SecretApprovalRequestReviewed;
+  | SecretApprovalRequestReview;
diff --git a/frontend/src/hooks/api/auditLogs/constants.tsx b/frontend/src/hooks/api/auditLogs/constants.tsx
index 445bda774..d348c7bb1 100644
--- a/frontend/src/hooks/api/auditLogs/constants.tsx
+++ b/frontend/src/hooks/api/auditLogs/constants.tsx
@@ -122,7 +122,7 @@ export const eventToNameMap: { [K in EventType]: string } = {
     "OIDC group membership mapping assigned user to groups",
   [EventType.OIDC_GROUP_MEMBERSHIP_MAPPING_REMOVE_USER]:
     "OIDC group membership mapping removed user from groups",
-  [EventType.SECRET_APPROVAL_REQUEST_REVIEWED]: "Review Secret Approval Request",
+  [EventType.SECRET_APPROVAL_REQUEST_REVIEW]: "Review Secret Approval Request",
   [EventType.CREATE_KMIP_CLIENT]: "Create KMIP client",
   [EventType.UPDATE_KMIP_CLIENT]: "Update KMIP client",
   [EventType.DELETE_KMIP_CLIENT]: "Delete KMIP client",
diff --git a/frontend/src/hooks/api/auditLogs/enums.tsx b/frontend/src/hooks/api/auditLogs/enums.tsx
index ad84508e7..76bb283dc 100644
--- a/frontend/src/hooks/api/auditLogs/enums.tsx
+++ b/frontend/src/hooks/api/auditLogs/enums.tsx
@@ -151,5 +151,5 @@ export enum EventType {
   KMIP_OPERATION_REVOKE = "kmip-operation-revoke",
   KMIP_OPERATION_LOCATE = "kmip-operation-locate",
   KMIP_OPERATION_REGISTER = "kmip-operation-register",
-  SECRET_APPROVAL_REQUEST_REVIEWED = "secret-approval-request-reviewed"
+  SECRET_APPROVAL_REQUEST_REVIEW = "secret-approval-request-review"
 }