awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-02 16:25:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2722 from Infisical/scott/secret-refrence-fixes

Browse Source 
Fix: Secret Reference Multiple References and Special Character Stripping
This commit is contained in:
Akhil Mohan
2024-11-12 22:49:18 +05:30
committed by GitHub
parent 2d2ad0724f 334a728259
commit d272c6217a
2 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/services/secret-v2-bridge/secret-v2-bridge-fns.ts
+4 -1
View File
@@ -518,7 +518,10 @@ export const expandSecretReferencesFactory = ({
} }
if (referencedSecretValue) { if (referencedSecretValue) {
expandedValue = expandedValue.replaceAll(interpolationSyntax, referencedSecretValue); expandedValue = expandedValue.replaceAll(
interpolationSyntax,
() => referencedSecretValue // prevents special characters from triggering replacement patterns
);
} }
} }
} }
backend/src/services/secret-v2-bridge/secret-v2-bridge-service.ts
+6 -2
View File
@@ -150,9 +150,13 @@ export const secretV2BridgeServiceFactory = ({
} }
}); });
if (referredSecrets.length !== references.length) if (
referredSecrets.length !==
new Set(references.map(({ secretKey, secretPath, environment }) => `${secretKey}.${secretPath}.${environment}`))
.size // only count unique references
)
throw new BadRequestError({ throw new BadRequestError({
message: `Referenced secret not found. Found only ${diff( message: `Referenced secret(s) not found: ${diff(
references.map((el) => el.secretKey), references.map((el) => el.secretKey),
referredSecrets.map((el) => el.key) referredSecrets.map((el) => el.key)
).join(",")}` ).join(",")}`