awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-06 11:27:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address review feedbacks

Browse Source
This commit is contained in:
Fang-Pen Lin
2025-11-07 09:21:19 -08:00
parent 136d755577
commit d2c8904e8f
2 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/ee/services/pki-acme/pki-acme-errors.ts
+3 -3
View File
@@ -14,13 +14,13 @@ export enum AcmeErrorType {
BadPublicKey = "badPublicKey", BadPublicKey = "badPublicKey",
BadRevocationReason = "badRevocationReason", BadRevocationReason = "badRevocationReason",
BadSignatureAlgorithm = "badSignatureAlgorithm", BadSignatureAlgorithm = "badSignatureAlgorithm",
CAA = "CAA", CAA = "caa",
Compound = "compound", Compound = "compound",
Connection = "connection", Connection = "connection",
DNS = "DNS", DNS = "dns",
ExternalAccountRequired = "externalAccountRequired", ExternalAccountRequired = "externalAccountRequired",
IncorrectResponse = "incorrectResponse", IncorrectResponse = "incorrectResponse",
IncorrectContact = "incorrectContact", InvalidContact = "invalidContact",
Malformed = "malformed", Malformed = "malformed",
OrderNotReady = "orderNotReady", OrderNotReady = "orderNotReady",
RateLimited = "rateLimited", RateLimited = "rateLimited",
backend/src/ee/services/pki-acme/pki-acme-service.ts
+7 -4
View File
@@ -614,10 +614,13 @@ export const pkiAcmeServiceFactory = ({
csr, csr,
notBefore: finalizingOrder.notBefore ? new Date(finalizingOrder.notBefore) : undefined, notBefore: finalizingOrder.notBefore ? new Date(finalizingOrder.notBefore) : undefined,
notAfter: finalizingOrder.notAfter ? new Date(finalizingOrder.notAfter) : undefined, notAfter: finalizingOrder.notAfter ? new Date(finalizingOrder.notAfter) : undefined,
validity: { validity: !finalizingOrder.notAfter
// TODO: read config from the profile to get the expiration time instead ? {
ttl: (24 * 60 * 60 * 1000).toString() // TODO: read config from the profile to get the expiration time instead
}, ttl: (24 * 60 * 60 * 1000).toString()
}
: // ttl is not used if notAfter is provided
({ ttl: "0" } as const),
enrollmentType: EnrollmentType.ACME enrollmentType: EnrollmentType.ACME
}); });
// TODO: associate the certificate with the order // TODO: associate the certificate with the order