feat: addressed rabbit and reptile feedback

This commit is contained in:
=
2025-04-28 19:48:56 +05:30
parent 58940f31e3
commit d3d76467ac
7 changed files with 22 additions and 15 deletions
@@ -1,7 +1,7 @@
export type TGithubOrgSyncConfig = {
id: string;
orgId: string;
githubAccessToken: string;
githubOrgAccessToken?: string;
githubOrgName: string;
createdAt: string;
isActive?: boolean;
@@ -110,6 +110,7 @@ export const formSchema = z.object({
"secret-scanning": generalPermissionSchema,
sso: generalPermissionSchema,
scim: generalPermissionSchema,
[OrgPermissionSubjects.GithubOrgSync]: generalPermissionSchema,
ldap: generalPermissionSchema,
billing: generalPermissionSchema,
identity: identityPermissionSchema,
@@ -63,6 +63,10 @@ const SIMPLE_PERMISSION_OPTIONS = [
title: "SCIM",
formName: "scim"
},
{
title: "GitHub Organization Sync",
formName: OrgPermissionSubjects.GithubOrgSync
},
{
title: "External KMS",
formName: OrgPermissionSubjects.Kms
@@ -145,7 +145,7 @@ export const GithubOrgSyncConfigModal = ({
<Button
variant="plain"
colorSchema="secondary"
onClick={() => handlePopUpToggle("deleteGithubOrgSyncConfig", false)}
onClick={() => handlePopUpToggle("githubOrgSyncConfig", false)}
>
Cancel
</Button>
@@ -163,7 +163,7 @@ export const GithubOrgSyncConfigModal = ({
<DeleteActionModal
isOpen={popUp.deleteGithubOrgSyncConfig.isOpen}
title="Are you sure want to remove GitHub organization sync?"
onChange={(isOpen) => handlePopUpToggle("githubOrgSyncConfig", isOpen)}
onChange={(isOpen) => handlePopUpToggle("deleteGithubOrgSyncConfig", isOpen)}
deleteKey="confirm"
onDeleteApproved={onDelete}
/>