greptile review fixes

This commit is contained in:
x032205
2025-05-22 20:41:35 -04:00
parent 5e803e76d7
commit d49c1e4b72
4 changed files with 5 additions and 7 deletions
@@ -1,3 +1,4 @@
import { logger } from "@app/lib/logger";
import { OrgServiceActor } from "@app/lib/types"; import { OrgServiceActor } from "@app/lib/types";
import { AppConnection } from "../app-connection-enums"; import { AppConnection } from "../app-connection-enums";
@@ -18,6 +19,7 @@ export const onePassConnectionService = (getAppConnection: TGetAppConnectionFunc
const vaults = await listOnePassVaults(appConnection); const vaults = await listOnePassVaults(appConnection);
return vaults; return vaults;
} catch (error) { } catch (error) {
logger.error(error, "Failed to establish connection with 1Password");
return []; return [];
} }
}; };
@@ -19,7 +19,7 @@ Infisical supports the use of [Service Accounts](https://developer.1password.com
![Click Connect Server](/images/app-connections/1password/click-connect-server.png) ![Click Connect Server](/images/app-connections/1password/click-connect-server.png)
</Step> </Step>
<Step title="Configure Connect Server"> <Step title="Configure Connect Server">
1. Input a name for you Connect Server 1. Input a name for your Connect Server
2. Click "Choose Vaults" and select the vaults you want to connect 2. Click "Choose Vaults" and select the vaults you want to connect
3. For each selected vault, click **Edit Access** and **Enable All** 3. For each selected vault, click **Edit Access** and **Enable All**
4. Click "Add Environment" 4. Click "Add Environment"
@@ -89,7 +89,7 @@ Infisical supports the use of [Service Accounts](https://developer.1password.com
--header 'Content-Type: application/json' \ --header 'Content-Type: application/json' \
--data '{ --data '{
"name": "my-1password-connection", "name": "my-1password-connection",
"method": "access-key", "method": "api-token",
"credentials": { "credentials": {
"instanceUrl": "https://1pass.example.com", "instanceUrl": "https://1pass.example.com",
"apiToken": "[PRIVATE TOKEN]" "apiToken": "[PRIVATE TOKEN]"
+1 -1
View File
@@ -93,7 +93,7 @@ description: "Learn how to configure a 1Password Sync for Infisical."
"syncOptions": { "syncOptions": {
"initialSyncBehavior": "overwrite-destination" "initialSyncBehavior": "overwrite-destination"
}, },
"destinationConfig": "destinationConfig": {
"vaultId": "..." "vaultId": "..."
} }
}' }'
@@ -69,10 +69,6 @@ export const OnePassSyncFields = () => {
</FormControl> </FormControl>
)} )}
/> />
<span className="text-sm text-bunker-300">
Not selecting a Build Configuration will sync your secrets to the entire project.
</span>
</> </>
); );
}; };