From faa83344a7b67a214e8ac555eb03b9cd30999c27 Mon Sep 17 00:00:00 2001 From: Sheen Capadngan Date: Mon, 18 Nov 2024 21:43:06 +0800 Subject: [PATCH 1/2] misc: address role slug issue in invite user endpoint --- backend/src/server/routes/v2/project-membership-router.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backend/src/server/routes/v2/project-membership-router.ts b/backend/src/server/routes/v2/project-membership-router.ts index 4aa03f33c..5a9060295 100644 --- a/backend/src/server/routes/v2/project-membership-router.ts +++ b/backend/src/server/routes/v2/project-membership-router.ts @@ -27,7 +27,7 @@ export const registerProjectMembershipRouter = async (server: FastifyZodProvider body: z.object({ emails: z.string().email().array().default([]).describe(PROJECT_USERS.INVITE_MEMBER.emails), usernames: z.string().array().default([]).describe(PROJECT_USERS.INVITE_MEMBER.usernames), - roleSlugs: z.string().array().optional().describe(PROJECT_USERS.INVITE_MEMBER.roleSlugs) + roleSlugs: z.string().array().min(1).optional().describe(PROJECT_USERS.INVITE_MEMBER.roleSlugs) }), response: { 200: z.object({ @@ -49,7 +49,7 @@ export const registerProjectMembershipRouter = async (server: FastifyZodProvider projects: [ { id: req.params.projectId, - projectRoleSlug: [ProjectMembershipRole.Member] + projectRoleSlug: req.body.roleSlugs ? req.body.roleSlugs : [ProjectMembershipRole.Member] } ] }); From 827931e416d2025e3c391cc3b1f1d213b58ac315 Mon Sep 17 00:00:00 2001 From: Sheen Capadngan Date: Mon, 18 Nov 2024 21:52:36 +0800 Subject: [PATCH 2/2] misc: addressed comment --- backend/src/server/routes/v2/project-membership-router.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/src/server/routes/v2/project-membership-router.ts b/backend/src/server/routes/v2/project-membership-router.ts index 5a9060295..0c3ceb01e 100644 --- a/backend/src/server/routes/v2/project-membership-router.ts +++ b/backend/src/server/routes/v2/project-membership-router.ts @@ -49,7 +49,7 @@ export const registerProjectMembershipRouter = async (server: FastifyZodProvider projects: [ { id: req.params.projectId, - projectRoleSlug: req.body.roleSlugs ? req.body.roleSlugs : [ProjectMembershipRole.Member] + projectRoleSlug: req.body.roleSlugs || [ProjectMembershipRole.Member] } ] });