awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-09 18:28:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug with updating overwritten secrets

Browse Source
This commit is contained in:
Daniel Hougaard
2023-11-28 12:07:02 +04:00
parent 8e33692cda
commit d5c5495475
2 changed files with 22 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/controllers/v3/secretsController.ts
+2
View File
@@ -1116,6 +1116,7 @@ export const updateSecretByName = async (req: Request, res: Response) => {
authData: req.authData authData: req.authData
}); });
if (secretReminderCron !== undefined) {
if ( if (
(secretReminderCron && existingSecret.secretReminderCron !== secretReminderCron) || (secretReminderCron && existingSecret.secretReminderCron !== secretReminderCron) ||
(secretReminderNote && existingSecret.secretReminderNote !== secretReminderNote) (secretReminderNote && existingSecret.secretReminderNote !== secretReminderNote)
@@ -1137,6 +1138,7 @@ export const updateSecretByName = async (req: Request, res: Response) => {
}); });
} }
} }
}
if (type !== "personal") { if (type !== "personal") {
const existingSecret = await SecretService.getSecret({ const existingSecret = await SecretService.getSecret({
backend/src/validation/secrets.ts
+1 -1
View File
@@ -368,7 +368,7 @@ export const UpdateSecretByNameV3 = z.object({
.trim() .trim()
.optional() .optional()
.nullable() .nullable()
.refine((val) => val === null || (val && isValidCron(val))), .refine((val) => val === null || val === undefined || (val && isValidCron(val))),
secretReminderNote: z.string().trim().nullable().optional(), secretReminderNote: z.string().trim().nullable().optional(),
tags: z.string().array().optional(), tags: z.string().array().optional(),