awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-08 09:27:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug with updating overwritten secrets

Browse Source
This commit is contained in:
Daniel Hougaard
2023-11-28 12:07:02 +04:00
parent 8e33692cda
commit d5c5495475
2 changed files with 22 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/controllers/v3/secretsController.ts
+21 -19
View File
@@ -1116,25 +1116,27 @@ export const updateSecretByName = async (req: Request, res: Response) => {
authData: req.authData authData: req.authData
}); });
if ( if (secretReminderCron !== undefined) {
(secretReminderCron && existingSecret.secretReminderCron !== secretReminderCron) || if (
(secretReminderNote && existingSecret.secretReminderNote !== secretReminderNote) (secretReminderCron && existingSecret.secretReminderCron !== secretReminderCron) ||
) { (secretReminderNote && existingSecret.secretReminderNote !== secretReminderNote)
await createReminder(existingSecret, { ) {
_id: existingSecret._id, await createReminder(existingSecret, {
secretReminderCron, _id: existingSecret._id,
secretReminderNote, secretReminderCron,
workspace: existingSecret.workspace secretReminderNote,
}); workspace: existingSecret.workspace
} else if ( });
secretReminderCron === null && } else if (
secretReminderNote === null && secretReminderCron === null &&
existingSecret.secretReminderCron secretReminderNote === null &&
) { existingSecret.secretReminderCron
await deleteReminder({ ) {
_id: existingSecret._id, await deleteReminder({
secretReminderCron: existingSecret.secretReminderCron _id: existingSecret._id,
}); secretReminderCron: existingSecret.secretReminderCron
});
}
} }
} }
backend/src/validation/secrets.ts
+1 -1
View File
@@ -368,7 +368,7 @@ export const UpdateSecretByNameV3 = z.object({
.trim() .trim()
.optional() .optional()
.nullable() .nullable()
.refine((val) => val === null || (val && isValidCron(val))), .refine((val) => val === null || val === undefined || (val && isValidCron(val))),
secretReminderNote: z.string().trim().nullable().optional(), secretReminderNote: z.string().trim().nullable().optional(),
tags: z.string().array().optional(), tags: z.string().array().optional(),