Fix bug with updating overwritten secrets

This commit is contained in:
Daniel Hougaard
2023-11-28 12:07:02 +04:00
parent 8e33692cda
commit d5c5495475
2 changed files with 22 additions and 20 deletions
@@ -1116,6 +1116,7 @@ export const updateSecretByName = async (req: Request, res: Response) => {
authData: req.authData
});
if (secretReminderCron !== undefined) {
if (
(secretReminderCron && existingSecret.secretReminderCron !== secretReminderCron) ||
(secretReminderNote && existingSecret.secretReminderNote !== secretReminderNote)
@@ -1137,6 +1138,7 @@ export const updateSecretByName = async (req: Request, res: Response) => {
});
}
}
}
if (type !== "personal") {
const existingSecret = await SecretService.getSecret({
+1 -1
View File
@@ -368,7 +368,7 @@ export const UpdateSecretByNameV3 = z.object({
.trim()
.optional()
.nullable()
.refine((val) => val === null || (val && isValidCron(val))),
.refine((val) => val === null || val === undefined || (val && isValidCron(val))),
secretReminderNote: z.string().trim().nullable().optional(),
tags: z.string().array().optional(),