awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-21 12:28:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address greptile comments

Browse Source
This commit is contained in:
Carlos Monastyrski
2025-09-16 10:22:34 -03:00
parent 5bfff46c16
commit d77726d9f3
23 changed files with 102 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/pages/cert-manager/IntegrationsListPage/components/PkiSyncsTab/PkiSyncTable/PkiSyncRow.tsx
+1 -1
View File
@@ -124,7 +124,7 @@ export const PkiSyncRow = ({
return (
<Tr
onClick={() => {
console.log("PKI Sync navigation:", { syncId: id, projectId });
// console.log("PKI Sync navigation:", { syncId: id, projectId });
navigate({
to: ROUTE_PATHS.CertManager.PkiSyncDetailsByIDPage.path,
params: {
frontend/src/pages/cert-manager/IntegrationsListPage/components/PkiSyncsTab/PkiSyncTable/PkiSyncsTable.tsx
+4 -2
View File
@@ -146,7 +146,9 @@ export const PkiSyncsTable = ({ pkiSyncs }: Props) => {
const destinationValues = getPkiSyncDestinationColValues(pkiSync);
return (
PKI_SYNC_MAP[destination].name.toLowerCase().includes(searchValue) ||
(PKI_SYNC_MAP[destination]?.name || "Unknown Service")
.toLowerCase()
.includes(searchValue) ||
name.toLowerCase().includes(searchValue) ||
(pkiSync.appConnectionName &&
pkiSync.appConnectionName.toLowerCase().includes(searchValue)) ||
@@ -209,7 +211,7 @@ export const PkiSyncsTable = ({ pkiSyncs }: Props) => {
const getColSortIcon = (col: PkiSyncsOrderBy) =>
orderDirection === OrderByDirection.DESC && orderBy === col ? faArrowUp : faArrowDown;
const isTableFiltered = Boolean(filters.destinations.length);
const isTableFiltered = Boolean(filters.destinations.length || filters.status.length);
const handleDelete = (pkiSync: PkiSyncData) => handlePopUpOpen("deleteSync", pkiSync);
frontend/src/pages/cert-manager/IntegrationsListPage/components/PkiSyncsTab/PkiSyncsTab.tsx
+1 -1
View File
@@ -88,7 +88,7 @@ export const PkiSyncsTab = () => {
{(isAllowed) => (
<Button
colorSchema="secondary"
type="submit"
type="button"
leftIcon={<FontAwesomeIcon icon={faPlus} />}
onClick={() => handlePopUpOpen("addSync")}
isDisabled={!isAllowed}