feat: changes based on reviews

backend/src/ee/routes/v1/gateway-router.ts

@@ -37,7 +37,7 @@ export const registerGatewayRouter = async (server: FastifyZodProvider) => {
           turnServerPassword: z.string(),
           turnServerRealm: z.string(),
           turnServerAddress: z.string(),
-          infisicalStaticIp: z.string()
+          infisicalStaticIp: z.string().optional()
         })
       }
     },

backend/src/ee/services/gateway/gateway-service.ts

@@ -97,12 +97,7 @@ export const gatewayServiceFactory = ({
       orgId: actorOrgId
     });
 
-    if (
-      !envCfg.GATEWAY_RELAY_AUTH_SECRET ||
-      !envCfg.GATEWAY_RELAY_ADDRESS ||
-      !envCfg.GATEWAY_INFISICAL_STATIC_IP_ADDRESS ||
-      !envCfg.GATEWAY_RELAY_REALM
-    ) {
+    if (!envCfg.GATEWAY_RELAY_AUTH_SECRET || !envCfg.GATEWAY_RELAY_ADDRESS || !envCfg.GATEWAY_RELAY_REALM) {
       throw new BadRequestError({
         message: "Gateway handshake failed due to missing instance configuration."
       });

backend/src/lib/gateway/index.ts

@@ -105,7 +105,10 @@ export const pingGatewayAndVerify = async ({
     }
   }
 
-  throw new Error(`Failed to ping gateway after ${maxRetries} attempts. Last error: ${lastError?.message}`);
+  logger.error(lastError);
+  throw new BadRequestError({
+    message: `Failed to ping gateway after ${maxRetries} attempts. Last error: ${lastError?.message}`
+  });
 };
 
 interface TProxyServer {
@@ -251,6 +254,9 @@ export const withGatewayProxy = async (
   try {
     // Execute the callback with the allocated port
     await callback(port);
+  } catch (err) {
+    logger.error(err, "Failed to proxy");
+    throw new BadRequestError({ message: (err as Error)?.message });
   } finally {
     // Ensure cleanup happens regardless of success or failure
     cleanup();