From d8d480f2bc4aaaef87b7bc8c3327b7a8f4e5c02e Mon Sep 17 00:00:00 2001 From: Maidul Islam Date: Fri, 15 Sep 2023 22:32:03 -0400 Subject: [PATCH] edge case: read write for non existing env in deniedPermissions --- backend/src/utils/setup/backfillData.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/backend/src/utils/setup/backfillData.ts b/backend/src/utils/setup/backfillData.ts index 6a0c58216..b420761a7 100644 --- a/backend/src/utils/setup/backfillData.ts +++ b/backend/src/utils/setup/backfillData.ts @@ -723,6 +723,13 @@ export const backfillPermission = async () => { if (ability === "read") secretAccessRule[environmentSlug].read = false; }); + // environments that are not listed in deniedPermissions should be set to allowed for both read & and write + membership.workspace.environments.forEach(env => { + if (!secretAccessRule?.[env.slug]) { + secretAccessRule[env.slug] = { read: true, write: true }; + } + }) + const secretPermissions: any = []; Object.entries(secretAccessRule).forEach(([envSlug, { read, write }]) => { if (read) { @@ -768,7 +775,7 @@ export const backfillPermission = async () => { const { membershipIds, permissions, workspaceId, organizationId } = value const membership_identity = crypto.randomBytes(3).toString("hex") const role = new Role({ - name: `Migrated Role [${membership_identity.toUpperCase()}]`, + name: `Limited [${membership_identity.toUpperCase()}]`, organization: organizationId, workspace: workspaceId, description: "This role was auto generated by Infisical in effort to migrate your project members to our new permission system",