mirror of
https://github.com/awatertrevi/infisical.git
synced 2026-10-14 22:51:53 +00:00
improvements: address feedback
This commit is contained in:
@@ -44,7 +44,7 @@ export const ValidateWindmillConnectionCredentialsSchema = z.discriminatedUnion(
|
||||
z.object({
|
||||
method: z
|
||||
.literal(WindmillConnectionMethod.AccessToken)
|
||||
.describe(AppConnections?.CREATE(AppConnection.Windmill).method),
|
||||
.describe(AppConnections.CREATE(AppConnection.Windmill).method),
|
||||
credentials: WindmillConnectionAccessTokenCredentialsSchema.describe(
|
||||
AppConnections.CREATE(AppConnection.Windmill).credentials
|
||||
)
|
||||
|
||||
@@ -36,11 +36,11 @@ const listWindmillVariables = async ({ instanceUrl, workspace, accessToken, path
|
||||
}
|
||||
);
|
||||
|
||||
// eslint-disable-next-line no-await-in-loop
|
||||
for await (const variable of variablesPage) {
|
||||
for (const variable of variablesPage) {
|
||||
const variableName = variable.path.replace(path, "");
|
||||
|
||||
if (variable.is_secret) {
|
||||
// eslint-disable-next-line no-await-in-loop
|
||||
const { data: variableValue } = await request.get<string>(
|
||||
`${instanceUrl}/api/w/${workspace}/variables/get_value/${variable.path}`,
|
||||
{
|
||||
|
||||
@@ -30,9 +30,9 @@ const WindmillSyncDestinationConfigSchema = z.object({
|
||||
val.split("/").length >= 3 &&
|
||||
val
|
||||
.split("/")
|
||||
.filter(Boolean)
|
||||
.every((segment) => pathCharacterValidator(segment)),
|
||||
'Invalid path - must follow Windmill path format. ex: "/f/folder/path/"'
|
||||
.slice(0, -1) // Remove last empty segment from trailing slash
|
||||
.every((segment) => segment && pathCharacterValidator(segment)),
|
||||
'Invalid path - must follow Windmill path format. ex: "f/folder/path/"'
|
||||
)
|
||||
.describe(SecretSyncs.DESTINATION_CONFIG.WINDMILL.path)
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user