improvements: address feedback

This commit is contained in:
Scott Wilson
2025-04-16 15:28:29 -07:00
parent 875ec6a24e
commit d9bd1ac878
8 changed files with 26 additions and 16 deletions
@@ -36,11 +36,11 @@ const listWindmillVariables = async ({ instanceUrl, workspace, accessToken, path
}
);
// eslint-disable-next-line no-await-in-loop
for await (const variable of variablesPage) {
for (const variable of variablesPage) {
const variableName = variable.path.replace(path, "");
if (variable.is_secret) {
// eslint-disable-next-line no-await-in-loop
const { data: variableValue } = await request.get<string>(
`${instanceUrl}/api/w/${workspace}/variables/get_value/${variable.path}`,
{
@@ -30,9 +30,9 @@ const WindmillSyncDestinationConfigSchema = z.object({
val.split("/").length >= 3 &&
val
.split("/")
.filter(Boolean)
.every((segment) => pathCharacterValidator(segment)),
'Invalid path - must follow Windmill path format. ex: "/f/folder/path/"'
.slice(0, -1) // Remove last empty segment from trailing slash
.every((segment) => segment && pathCharacterValidator(segment)),
'Invalid path - must follow Windmill path format. ex: "f/folder/path/"'
)
.describe(SecretSyncs.DESTINATION_CONFIG.WINDMILL.path)
});