From 8ed0a1de849237a30f7cd7cf82a1701e703ac4d2 Mon Sep 17 00:00:00 2001 From: Scott Wilson Date: Mon, 23 Jun 2025 18:01:38 -0700 Subject: [PATCH 1/2] fix: correct window open for share your own secret link to handle self-hosted --- .../ViewSharedSecretByIDPage/components/PasswordContainer.tsx | 2 +- .../ViewSharedSecretByIDPage/components/SecretContainer.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/frontend/src/pages/public/ViewSharedSecretByIDPage/components/PasswordContainer.tsx b/frontend/src/pages/public/ViewSharedSecretByIDPage/components/PasswordContainer.tsx index a8030a70a..2d9ddf29a 100644 --- a/frontend/src/pages/public/ViewSharedSecretByIDPage/components/PasswordContainer.tsx +++ b/frontend/src/pages/public/ViewSharedSecretByIDPage/components/PasswordContainer.tsx @@ -70,7 +70,7 @@ export const PasswordContainer = ({ colorSchema="primary" variant="outline_bg" size="sm" - onClick={() => window.open("https://app.infisical.com/share-secret", "_blank")} + onClick={() => window.open("/share-secret", "_blank")} rightIcon={} > Share Your Own Secret diff --git a/frontend/src/pages/public/ViewSharedSecretByIDPage/components/SecretContainer.tsx b/frontend/src/pages/public/ViewSharedSecretByIDPage/components/SecretContainer.tsx index 3130f3c70..4f22c95a2 100644 --- a/frontend/src/pages/public/ViewSharedSecretByIDPage/components/SecretContainer.tsx +++ b/frontend/src/pages/public/ViewSharedSecretByIDPage/components/SecretContainer.tsx @@ -76,7 +76,7 @@ export const SecretContainer = ({ secret, secretKey: key }: Props) => { colorSchema="primary" variant="outline_bg" size="sm" - onClick={() => window.open("https://app.infisical.com/share-secret", "_blank")} + onClick={() => window.open("/share-secret", "_blank")} rightIcon={} > Share Your Own Secret From 198e74cd880e4ae66d5fd345b125744072e561ec Mon Sep 17 00:00:00 2001 From: Scott Wilson Date: Mon, 23 Jun 2025 18:05:48 -0700 Subject: [PATCH 2/2] fix: include nooppener in window.open --- .../ViewSharedSecretByIDPage/components/PasswordContainer.tsx | 2 +- .../ViewSharedSecretByIDPage/components/SecretContainer.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/frontend/src/pages/public/ViewSharedSecretByIDPage/components/PasswordContainer.tsx b/frontend/src/pages/public/ViewSharedSecretByIDPage/components/PasswordContainer.tsx index 2d9ddf29a..8beb2e74b 100644 --- a/frontend/src/pages/public/ViewSharedSecretByIDPage/components/PasswordContainer.tsx +++ b/frontend/src/pages/public/ViewSharedSecretByIDPage/components/PasswordContainer.tsx @@ -70,7 +70,7 @@ export const PasswordContainer = ({ colorSchema="primary" variant="outline_bg" size="sm" - onClick={() => window.open("/share-secret", "_blank")} + onClick={() => window.open("/share-secret", "_blank", "noopener")} rightIcon={} > Share Your Own Secret diff --git a/frontend/src/pages/public/ViewSharedSecretByIDPage/components/SecretContainer.tsx b/frontend/src/pages/public/ViewSharedSecretByIDPage/components/SecretContainer.tsx index 4f22c95a2..e4074b675 100644 --- a/frontend/src/pages/public/ViewSharedSecretByIDPage/components/SecretContainer.tsx +++ b/frontend/src/pages/public/ViewSharedSecretByIDPage/components/SecretContainer.tsx @@ -76,7 +76,7 @@ export const SecretContainer = ({ secret, secretKey: key }: Props) => { colorSchema="primary" variant="outline_bg" size="sm" - onClick={() => window.open("/share-secret", "_blank")} + onClick={() => window.open("/share-secret", "_blank", "noopener")} rightIcon={} > Share Your Own Secret