awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-05 16:26:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

mics: added missing github app connection usage

Browse Source
This commit is contained in:
Sheen Capadngan
2025-09-03 21:30:48 +08:00
parent ec39f84719
commit e00df2c659
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/services/app-connection/github/github-connection-fns.ts
+4 -2
View File
@@ -164,7 +164,8 @@ export const requestWithGitHubGateway = async <T>(
export const getGitHubAppAuthToken = async ( export const getGitHubAppAuthToken = async (
appConnection: TGitHubConnection, appConnection: TGitHubConnection,
gatewayService: Pick<TGatewayServiceFactory, "fnGetGatewayClientTlsByGatewayId"> gatewayService: Pick<TGatewayServiceFactory, "fnGetGatewayClientTlsByGatewayId">,
gatewayV2Service: Pick<TGatewayV2ServiceFactory, "getPlatformConnectionDetailsByGatewayId">
) => { ) => {
const appCfg = getConfig(); const appCfg = getConfig();
const appId = appCfg.INF_APP_CONNECTION_GITHUB_APP_ID; const appId = appCfg.INF_APP_CONNECTION_GITHUB_APP_ID;
@@ -200,6 +201,7 @@ export const getGitHubAppAuthToken = async (
const response = await requestWithGitHubGateway<{ token: string; expires_at: string }>( const response = await requestWithGitHubGateway<{ token: string; expires_at: string }>(
appConnection, appConnection,
gatewayService, gatewayService,
gatewayV2Service,
{ {
url: `https://${apiBaseUrl}/app/installations/${installationId}/access_tokens`, url: `https://${apiBaseUrl}/app/installations/${installationId}/access_tokens`,
method: "POST", method: "POST",
@@ -249,7 +251,7 @@ export const makePaginatedGitHubRequest = async <T, R = T[]>(
const token = const token =
method === GitHubConnectionMethod.OAuth method === GitHubConnectionMethod.OAuth
? credentials.accessToken ? credentials.accessToken
: await getGitHubAppAuthToken(appConnection, gatewayService); : await getGitHubAppAuthToken(appConnection, gatewayService, gatewayV2Service);
const baseUrl = `https://${await getGitHubInstanceApiUrl(appConnection)}${path}`; const baseUrl = `https://${await getGitHubInstanceApiUrl(appConnection)}${path}`;
const initialUrlObj = new URL(baseUrl); const initialUrlObj = new URL(baseUrl);
backend/src/services/secret-sync/github/github-sync-fns.ts
+2 -2
View File
@@ -214,7 +214,7 @@ export const GithubSyncFns = {
const token = const token =
connection.method === GitHubConnectionMethod.OAuth connection.method === GitHubConnectionMethod.OAuth
? connection.credentials.accessToken ? connection.credentials.accessToken
: await getGitHubAppAuthToken(connection, gatewayService); : await getGitHubAppAuthToken(connection, gatewayService, gatewayV2Service);
const encryptedSecrets = await getEncryptedSecrets(secretSync, gatewayService, gatewayV2Service); const encryptedSecrets = await getEncryptedSecrets(secretSync, gatewayService, gatewayV2Service);
const publicKey = await getPublicKey(secretSync, gatewayService, gatewayV2Service, token); const publicKey = await getPublicKey(secretSync, gatewayService, gatewayV2Service, token);
@@ -272,7 +272,7 @@ export const GithubSyncFns = {
const token = const token =
connection.method === GitHubConnectionMethod.OAuth connection.method === GitHubConnectionMethod.OAuth
? connection.credentials.accessToken ? connection.credentials.accessToken
: await getGitHubAppAuthToken(connection, gatewayService); : await getGitHubAppAuthToken(connection, gatewayService, gatewayV2Service);
const encryptedSecrets = await getEncryptedSecrets(secretSync, gatewayService, gatewayV2Service); const encryptedSecrets = await getEncryptedSecrets(secretSync, gatewayService, gatewayV2Service);