greptile reviews

backend/src/ee/services/pam-resource/pam-resource-service.ts

@@ -177,11 +177,13 @@ export const pamResourceServiceFactory = ({
       updateDoc.encryptedRotationAccountCredentials = null;
 
       if (rotationAccountCredentials) {
-        const decryptedConnectionDetails = await decryptResourceConnectionDetails({
-          encryptedConnectionDetails: resource.encryptedConnectionDetails,
-          projectId: resource.projectId,
-          kmsService
-        });
+        const decryptedConnectionDetails =
+          connectionDetails ??
+          (await decryptResourceConnectionDetails({
+            encryptedConnectionDetails: resource.encryptedConnectionDetails,
+            projectId: resource.projectId,
+            kmsService
+          }));
 
         const factory = PAM_RESOURCE_FACTORY_MAP[resource.resourceType as PamResource](
           resource.resourceType as PamResource,

backend/src/ee/services/pam-resource/shared/sql/sql-resource-schemas.ts

@@ -16,6 +16,6 @@ export const BaseSqlResourceConnectionDetailsSchema = z.object({
 
 // Accounts
 export const BaseSqlAccountCredentialsSchema = z.object({
-  username: z.string().trim().min(1),
-  password: z.string().trim().min(1)
+  username: z.string().trim().min(1).max(63),
+  password: z.string().trim().min(1).max(256)
 });

backend/src/services/pam-account-rotation/pam-account-rotation-queue.ts

@@ -43,7 +43,7 @@ export const pamAccountRotationServiceFactory = ({
       {
         batchSize: 1,
         workerCount: 1,
-        pollingIntervalSeconds: 1 // 5 * 60
+        pollingIntervalSeconds: 5 * 60
       }
     );