awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-04 08:26:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

greptile reviews

Browse Source
This commit is contained in:
x032205
2025-10-16 19:27:53 -04:00
parent faa97f3e67
commit e1214a1d2b
6 changed files with 17 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/ee/services/pam-resource/pam-resource-service.ts
+7 -5
View File
@@ -177,11 +177,13 @@ export const pamResourceServiceFactory = ({
updateDoc.encryptedRotationAccountCredentials = null; updateDoc.encryptedRotationAccountCredentials = null;
if (rotationAccountCredentials) { if (rotationAccountCredentials) {
const decryptedConnectionDetails = await decryptResourceConnectionDetails({ const decryptedConnectionDetails =
encryptedConnectionDetails: resource.encryptedConnectionDetails, connectionDetails ??
projectId: resource.projectId, (await decryptResourceConnectionDetails({
kmsService encryptedConnectionDetails: resource.encryptedConnectionDetails,
}); projectId: resource.projectId,
kmsService
}));
const factory = PAM_RESOURCE_FACTORY_MAP[resource.resourceType as PamResource]( const factory = PAM_RESOURCE_FACTORY_MAP[resource.resourceType as PamResource](
resource.resourceType as PamResource, resource.resourceType as PamResource,
backend/src/ee/services/pam-resource/shared/sql/sql-resource-schemas.ts
+2 -2
View File
@@ -16,6 +16,6 @@ export const BaseSqlResourceConnectionDetailsSchema = z.object({
// Accounts // Accounts
export const BaseSqlAccountCredentialsSchema = z.object({ export const BaseSqlAccountCredentialsSchema = z.object({
username: z.string().trim().min(1), username: z.string().trim().min(1).max(63),
password: z.string().trim().min(1) password: z.string().trim().min(1).max(256)
}); });
backend/src/services/pam-account-rotation/pam-account-rotation-queue.ts
+1 -1
View File
@@ -43,7 +43,7 @@ export const pamAccountRotationServiceFactory = ({
{ {
batchSize: 1, batchSize: 1,
workerCount: 1, workerCount: 1,
pollingIntervalSeconds: 1 // 5 * 60 pollingIntervalSeconds: 5 * 60
} }
); );
frontend/src/pages/pam/PamAccountsPage/components/PamAccountForm/PamAccountForm.tsx
-2
View File
@@ -34,8 +34,6 @@ const CreateForm = ({
}: CreateFormProps) => { }: CreateFormProps) => {
const createPamAccount = useCreatePamAccount(); const createPamAccount = useCreatePamAccount();
console.log({ folderId });
const onSubmit = async ( const onSubmit = async (
formData: DiscriminativePick< formData: DiscriminativePick<
TPamAccount, TPamAccount,
frontend/src/pages/pam/PamAccountsPage/components/PamAccountForm/RotateAccountFields.tsx
+1 -1
View File
@@ -26,7 +26,7 @@ export const RotateAccountFields = () => {
<FormControl isError={Boolean(error)} errorText={error?.message} className="mb-0"> <FormControl isError={Boolean(error)} errorText={error?.message} className="mb-0">
<Switch <Switch
className="ml-0 bg-mineshaft-400/80 shadow-inner data-[state=checked]:bg-green/80" className="ml-0 bg-mineshaft-400/80 shadow-inner data-[state=checked]:bg-green/80"
id="can-remove-certificates" id="rotation-enabled"
thumbClassName="bg-mineshaft-800" thumbClassName="bg-mineshaft-800"
onCheckedChange={onChange} onCheckedChange={onChange}
isChecked={value} isChecked={value}
frontend/src/pages/pam/PamAccountsPage/components/PamAccountForm/shared/sql-account-schemas.ts
+6 -2
View File
@@ -5,6 +5,10 @@ export const BaseSqlAccountSchema = z.object({
.string() .string()
.trim() .trim()
.min(1, "Username required") .min(1, "Username required")
.max(255, "Username must be 255 characters or less"), .max(63, "Username must be 63 characters or less"),
password: z.string().trim().min(1, "Password required") password: z
.string()
.trim()
.min(1, "Password required")
.max(256, "Password must be 256 characters or less")
}); });