From e4655532a8cb21d547ea7781a2f48b2b0fe3eaba Mon Sep 17 00:00:00 2001
From: Fang-Pen Lin <hello@fangpenlin.com>
Date: Thu, 30 Oct 2025 12:55:24 -0700
Subject: [PATCH] More asserts

---
 .../bdd/features/pki/acme/new-order.feature   |  3 ++-
 backend/bdd/features/steps/pki_acme.py        | 22 ++++++++++++++-----
 2 files changed, 19 insertions(+), 6 deletions(-)

diff --git a/backend/bdd/features/pki/acme/new-order.feature b/backend/bdd/features/pki/acme/new-order.feature
index a80c3ed58..dec1c7c42 100644
--- a/backend/bdd/features/pki/acme/new-order.feature
+++ b/backend/bdd/features/pki/acme/new-order.feature
@@ -16,4 +16,5 @@ Feature: New Order
     Then I create a RSA private key pair as cert_key
     Then I sign the certificate signing request csr with private key cert_key and output it as csr_pem in PEM format
     Then I submit the certificate signing request PEM csr_pem certificate order to the ACME server as order
-    Then the value order.uri should be true for startswith("{BASE_URL}/api/v1/pki/acme/profiles/{acme_profile.id}/orders/")
+    Then the value order.uri should be true for jq startswith("{BASE_URL}/api/v1/pki/acme/profiles/{acme_profile.id}/orders/")
+    Then the value order.body.status.name should be "pending"
diff --git a/backend/bdd/features/steps/pki_acme.py b/backend/bdd/features/steps/pki_acme.py
index 7cf5c4980..cb8ee88c9 100644
--- a/backend/bdd/features/steps/pki_acme.py
+++ b/backend/bdd/features/steps/pki_acme.py
@@ -38,6 +38,14 @@ def replace_vars(payload: dict | list | int | float | str, vars: dict):
         return payload
 
 
+def eval_var(context: Context, var_path: str):
+    parts = var_path.split(".", 1)
+    value = context.vars[parts[0]]
+    if len(parts) == 2:
+        value = glom.glom(value, parts[1])
+    return value
+
+
 @given('I have an ACME cert profile as "{profile_var}"')
 def step_impl(context: Context, profile_var: str):
     # TODO: Fixed value for now, just to make test much easier,
@@ -158,11 +166,15 @@ def step_impl(context: Context, csr_var: str, pk_var: str, pem_var: str):
     )
 
 
-@then("the value {var_path} should be true for {query}")
+@then("the value {var_path} should be true for jq {query}")
 def step_impl(context: Context, var_path: str, query: str):
-    parts = var_path.split(".", 1)
-    value = context.vars[parts[0]]
-    if len(parts) == 2:
-        value = glom.glom(value, parts[1])
+    value = eval_var(context, var_path)
     result = jq.compile(replace_vars(query, context.vars)).input_value(value).first()
     assert result, f"{value} does not match {query}"
+
+
+@then("the value {var_path} should be {expected}")
+def step_impl(context: Context, var_path: str, expected: str):
+    value = eval_var(context, var_path)
+    expected_value = json.loads(expected)
+    assert value == expected_value, f"{value:!r} does not match {expected_value:!r}"