awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-06 00:26:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Support for RegExp + workflow test

Browse Source
This commit is contained in:
x032205
2025-06-05 16:53:19 -04:00
parent 617d07177c
commit e57935a7d3
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/check-non-re2-regex.yml
+11 -11
View File
@@ -22,30 +22,30 @@ jobs:
grep '^+' diff.txt | grep -v '^+++' | sed 's/^\+//' > added_lines.txt grep '^+' diff.txt | grep -v '^+++' | sed 's/^\+//' > added_lines.txt
if [ ! -s added_lines.txt ]; then if [ ! -s added_lines.txt ]; then
echo "✅ No raw regex literals to check in backend." echo "✅ No added lines in backend/ to check for regex usage."
exit 0 exit 0
fi fi
raw_regex_pattern='(^|[^A-Za-z0-9_])\/[^\/]+\/[gimsuy]*' regex_usage_pattern='(^|[^A-Za-z0-9_])(\/[^\/]+\/[gimsuy]*|new RegExp\()'
# Find all added lines that contain the raw_regex_pattern. # Find all added lines that contain the regex_usage_pattern.
grep -E "$raw_regex_pattern" added_lines.txt > potential_violations.txt grep -E "$regex_usage_pattern" added_lines.txt > potential_violations.txt
if [ -s potential_violations.txt ]; then # If any lines match the raw regex pattern if [ -s potential_violations.txt ]; then # If any lines match the regex usage pattern
# Filter out lines that also contain the string 'new RE2'. # Filter out lines that also contain the string 'new RE2'
grep -v 'new RE2' potential_violations.txt > actual_violations.txt grep -v 'new RE2' potential_violations.txt > actual_violations.txt
if [ -s actual_violations.txt ]; then # If there are lines left after filtering out 'new RE2' if [ -s actual_violations.txt ]; then # If there are lines left after filtering out 'new RE2'
echo "🚨 ERROR: Found raw regex usage in added/modified backend code." echo "🚨 ERROR: Found forbidden regex pattern (raw literal '/.../' or 'new RegExp(...)') in added/modified backend code."
echo "Please use 'new RE2(...)' for all regular expressions in the backend." echo "Please use 'new RE2(...)' for all regular expressions in the backend."
echo "Offending lines:" echo "Offending lines:"
cat actual_violations.txt cat actual_violations.txt
exit 1 exit 1
else else
# All lines that matched raw_regex_pattern also contained 'new RE2'. # All lines that matched regex_usage_pattern also contained 'new RE2'.
echo "✅ No forbidden raw regex literals found in backend." echo "✅ All identified regex usages are correctly using 'new RE2(...)'."
fi fi
else else
# No lines matched the raw_regex_pattern at all. # No lines matched the regex_usage_pattern at all.
echo "✅ No raw regex literals found in added/modified backend lines." echo "✅ No raw regex literals ('/.../') or 'new RegExp(...)' usage found in added/modified backend lines."
fi fi
backend/src/ee/services/dynamic-secret/providers/ldap.ts
+1 -1
View File
@@ -202,7 +202,7 @@ export const LdapProvider = (): TDynamicProviderFns => {
const client = await $getClient(providerInputs); const client = await $getClient(providerInputs);
if (providerInputs.credentialType === LdapCredentialType.Static) { if (providerInputs.credentialType === LdapCredentialType.Static) {
const dnRegex = new RE2("^dn:\\s*(.+)", "m"); const dnRegex = new RegExp("^dn:\\s*(.+)", "m");
const dnMatch = dnRegex.exec(providerInputs.rotationLdif); const dnMatch = dnRegex.exec(providerInputs.rotationLdif);
if (dnMatch) { if (dnMatch) {