From e696bff00471cd8142c786cc3899bade9a0b79de Mon Sep 17 00:00:00 2001
From: Sheen Capadngan <sheensantoscapadngan@gmail.com>
Date: Mon, 10 Jun 2024 21:08:14 +0800
Subject: [PATCH] misc: optimized prune orphan snapshots

---
 .../src/ee/services/secret-snapshot/snapshot-dal.ts   | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/backend/src/ee/services/secret-snapshot/snapshot-dal.ts b/backend/src/ee/services/secret-snapshot/snapshot-dal.ts
index d2dab8e06..12897e6b9 100644
--- a/backend/src/ee/services/secret-snapshot/snapshot-dal.ts
+++ b/backend/src/ee/services/secret-snapshot/snapshot-dal.ts
@@ -434,13 +434,12 @@ export const snapshotDALFactory = (db: TDbClient) => {
 
       // cleanup orphaned snapshots (those that don't belong to an existing folder and folder version)
       await db(TableName.Snapshot)
-        // eslint-disable-next-line func-names
         .whereNotIn("folderId", function () {
-          void this.select("folderId").from(TableName.SecretFolderVersion);
-        })
-        // eslint-disable-next-line func-names
-        .whereNotIn("folderId", function () {
-          void this.select("folderId").from(TableName.SecretFolder);
+          void this.select("folderId")
+            .from(TableName.SecretFolderVersion)
+            .union(function () {
+              void this.select("id").from(TableName.SecretFolder);
+            });
         })
         .delete();
     } catch (error) {