Fix: Add missing actor auth method to permission checks

This commit is contained in:
Daniel Hougaard
2024-03-17 18:49:29 +01:00
parent f5f20fbdca
commit e89503f00f
@@ -432,12 +432,20 @@ export const projectServiceFactory = ({
return updatedProject; return updatedProject;
}; };
const upgradeProject = async ({ projectId, actor, actorId, actorAuthMethod, userPrivateKey }: TUpgradeProjectDTO) => { const upgradeProject = async ({
projectId,
actor,
actorId,
actorAuthMethod,
actorOrgId,
userPrivateKey
}: TUpgradeProjectDTO) => {
const { permission, hasRole } = await permissionService.getProjectPermission( const { permission, hasRole } = await permissionService.getProjectPermission(
actor, actor,
actorId, actorId,
projectId, projectId,
actorAuthMethod actorAuthMethod,
actorOrgId
); );
ForbiddenError.from(permission).throwUnlessCan(ProjectPermissionActions.Delete, ProjectPermissionSub.Project); ForbiddenError.from(permission).throwUnlessCan(ProjectPermissionActions.Delete, ProjectPermissionSub.Project);
@@ -462,8 +470,20 @@ export const projectServiceFactory = ({
}); });
}; };
const getProjectUpgradeStatus = async ({ projectId, actor, actorAuthMethod, actorId }: TProjectPermission) => { const getProjectUpgradeStatus = async ({
const { permission } = await permissionService.getProjectPermission(actor, actorId, projectId, actorAuthMethod); projectId,
actor,
actorAuthMethod,
actorOrgId,
actorId
}: TProjectPermission) => {
const { permission } = await permissionService.getProjectPermission(
actor,
actorId,
projectId,
actorAuthMethod,
actorOrgId
);
ForbiddenError.from(permission).throwUnlessCan(ProjectPermissionActions.Read, ProjectPermissionSub.Secrets); ForbiddenError.from(permission).throwUnlessCan(ProjectPermissionActions.Read, ProjectPermissionSub.Secrets);
const project = await projectDAL.findProjectById(projectId); const project = await projectDAL.findProjectById(projectId);