diff --git a/frontend/src/views/Project/IdentityDetailsPage/IdentityDetailPage.tsx b/frontend/src/views/Project/IdentityDetailsPage/IdentityDetailPage.tsx index d924c5230..29c7a7631 100644 --- a/frontend/src/views/Project/IdentityDetailsPage/IdentityDetailPage.tsx +++ b/frontend/src/views/Project/IdentityDetailsPage/IdentityDetailPage.tsx @@ -10,7 +10,7 @@ import { withProjectPermission } from "@app/hoc"; import { useGetWorkspaceIdentityMembershipDetails } from "@app/hooks/api"; import { IdentityProjectAdditionalPrivilegeSection } from "./components/IdentityProjectAdditionalPrivilegeSection"; -import { IdentityRoleDetailsSection } from "./components/IdentityRoleDetailsSectiona"; +import { IdentityRoleDetailsSection } from "./components/IdentityRoleDetailsSection"; export const IdentityDetailsPage = withProjectPermission( () => { diff --git a/frontend/src/views/Project/IdentityDetailsPage/components/IdentityProjectAdditionalPrivilegeSection/IdentityProjectAdditionalPrivilegeModifySection.tsx b/frontend/src/views/Project/IdentityDetailsPage/components/IdentityProjectAdditionalPrivilegeSection/IdentityProjectAdditionalPrivilegeModifySection.tsx index a53b3b649..cabec7f2a 100644 --- a/frontend/src/views/Project/IdentityDetailsPage/components/IdentityProjectAdditionalPrivilegeSection/IdentityProjectAdditionalPrivilegeModifySection.tsx +++ b/frontend/src/views/Project/IdentityDetailsPage/components/IdentityProjectAdditionalPrivilegeSection/IdentityProjectAdditionalPrivilegeModifySection.tsx @@ -167,7 +167,7 @@ export const IdentityProjectAdditionalPrivilegeModifySection = ({ onGoBack(); } catch (err) { console.log(err); - createNotification({ type: "error", text: "Failed to update role" }); + createNotification({ type: "error", text: "Failed to update privilege" }); } }; @@ -177,7 +177,7 @@ export const IdentityProjectAdditionalPrivilegeModifySection = ({ privilegeTemporaryAccess?.isTemporary && new Date() > new Date(privilegeTemporaryAccess.temporaryAccessEndTime || ""); let text = "Permanent"; - let toolTipText = "Non expiry access"; + let toolTipText = "Non-Expiring Access"; if (isTemporary) { if (isExpired) { @@ -206,7 +206,14 @@ export const IdentityProjectAdditionalPrivilegeModifySection = ({ -

Edit Additional Privilege

+
+

+ Edit Additional Privileges +

+

+ Additional privileges take precedence over roles when permissions conflict +

+
{isDirty && ( @@ -242,7 +249,7 @@ export const IdentityProjectAdditionalPrivilegeModifySection = ({ leftIcon={} isDisabled={isDisabled} > - New policy + New Policy @@ -297,7 +304,7 @@ export const IdentityProjectAdditionalPrivilegeModifySection = ({ >
- Configure timed access + Configure Timed Access
{isExpired && Expired} {(isAllowed) => ( new Date(privilegeDetails.temporaryAccessEndTime || ""); let text = "Permanent"; - let toolTipText = "Non expiry access"; + let toolTipText = "Non-Expiring Access"; if (privilegeDetails.isTemporary) { if (isExpired) { text = "Access Expired"; @@ -194,7 +194,7 @@ export const IdentityProjectAdditionalPrivilegeSection = ({ identityMembershipDe I={ProjectPermissionActions.Edit} a={ProjectPermissionSub.Identity} renderTooltip - allowedLabel="Remove role" + allowedLabel="Remove Role" > {(isAllowed) => ( {!isLoading && !userProjectPrivileges?.length && ( - + )}
diff --git a/frontend/src/views/Project/IdentityDetailsPage/components/IdentityRoleDetailsSectiona/IdentityRoleDetailsSection.tsx b/frontend/src/views/Project/IdentityDetailsPage/components/IdentityRoleDetailsSection/IdentityRoleDetailsSection.tsx similarity index 96% rename from frontend/src/views/Project/IdentityDetailsPage/components/IdentityRoleDetailsSectiona/IdentityRoleDetailsSection.tsx rename to frontend/src/views/Project/IdentityDetailsPage/components/IdentityRoleDetailsSection/IdentityRoleDetailsSection.tsx index 018bc1d5e..613c61948 100644 --- a/frontend/src/views/Project/IdentityDetailsPage/components/IdentityRoleDetailsSectiona/IdentityRoleDetailsSection.tsx +++ b/frontend/src/views/Project/IdentityDetailsPage/components/IdentityRoleDetailsSection/IdentityRoleDetailsSection.tsx @@ -56,7 +56,7 @@ export const IdentityRoleDetailsSection = ({ identityId: identityMembershipDetails.identity.id, roles: updatedRole }); - createNotification({ type: "success", text: "Successfully removed the role" }); + createNotification({ type: "success", text: "Successfully removed role" }); handlePopUpClose("deleteRole"); } catch (err) { console.log(err); @@ -111,7 +111,7 @@ export const IdentityRoleDetailsSection = ({ new Date() > new Date(roleDetails.temporaryAccessEndTime || ""); let text = "Permanent"; - let toolTipText = "Non expiry access"; + let toolTipText = "Non-Expiring Access"; if (roleDetails.isTemporary) { if (isExpired) { text = "Access Expired"; @@ -154,7 +154,7 @@ export const IdentityRoleDetailsSection = ({ I={ProjectPermissionActions.Edit} a={ProjectPermissionSub.Member} renderTooltip - allowedLabel="Remove role" + allowedLabel="Remove Role" > {(isAllowed) => ( handlePopUpToggle("modifyRole", isOpen)} > - + diff --git a/frontend/src/views/Project/IdentityDetailsPage/components/IdentityRoleDetailsSectiona/IdentityRoleModify.tsx b/frontend/src/views/Project/IdentityDetailsPage/components/IdentityRoleDetailsSection/IdentityRoleModify.tsx similarity index 97% rename from frontend/src/views/Project/IdentityDetailsPage/components/IdentityRoleDetailsSectiona/IdentityRoleModify.tsx rename to frontend/src/views/Project/IdentityDetailsPage/components/IdentityRoleDetailsSection/IdentityRoleModify.tsx index a0c629045..220bdf99f 100644 --- a/frontend/src/views/Project/IdentityDetailsPage/components/IdentityRoleDetailsSectiona/IdentityRoleModify.tsx +++ b/frontend/src/views/Project/IdentityDetailsPage/components/IdentityRoleDetailsSection/IdentityRoleModify.tsx @@ -122,7 +122,7 @@ export const IdentityRoleModify = ({ identityProjectMembership }: Props) => { }); createNotification({ text: "Successfully updated roles", type: "success" }); } catch (err) { - createNotification({ text: "Failed to update role", type: "error" }); + createNotification({ text: "Failed to update roles", type: "error" }); } }; @@ -177,7 +177,7 @@ export const IdentityRoleModify = ({ identityProjectMembership }: Props) => { new Date(temporaryAccess.temporaryAccessEndTime || ""), "yyyy-MM-dd HH:mm:ss" )}` - : "Non expiry access" + : "Non-Expiring Access" } > @@ -295,7 +295,7 @@ export const MembershipProjectAdditionalPrivilegeModifySection = ({ >
- Configure timed access + Configure Timed Access
{isExpired && Expired} {(isAllowed) => ( new Date(roleDetails.temporaryAccessEndTime || ""); let text = "Permanent"; - let toolTipText = "Non expiry access"; + let toolTipText = "Non-Expiring Access"; if (roleDetails.isTemporary) { if (isExpired) { text = "Access Expired"; @@ -165,7 +165,7 @@ export const MemberRoleDetailsSection = ({ I={ProjectPermissionActions.Edit} a={ProjectPermissionSub.Member} renderTooltip - allowedLabel="Remove role" + allowedLabel="Remove Role" > {(isAllowed) => ( handlePopUpToggle("modifyRole", isOpen)} > - + {}} /> diff --git a/frontend/src/views/Project/MemberDetailsPage/components/MemberRoleDetailsSection/MemberRoleModify.tsx b/frontend/src/views/Project/MemberDetailsPage/components/MemberRoleDetailsSection/MemberRoleModify.tsx index 973e2ac13..1dd223cb5 100644 --- a/frontend/src/views/Project/MemberDetailsPage/components/MemberRoleDetailsSection/MemberRoleModify.tsx +++ b/frontend/src/views/Project/MemberDetailsPage/components/MemberRoleDetailsSection/MemberRoleModify.tsx @@ -136,7 +136,7 @@ export const MemberRoleModify = ({ projectMember, onOpenUpgradeModal }: Props) = }); createNotification({ text: "Successfully updated roles", type: "success" }); } catch (err) { - createNotification({ text: "Failed to update role", type: "error" }); + createNotification({ text: "Failed to update roles", type: "error" }); } }; @@ -191,7 +191,7 @@ export const MemberRoleModify = ({ projectMember, onOpenUpgradeModal }: Props) = new Date(temporaryAccess.temporaryAccessEndTime || ""), "yyyy-MM-dd HH:mm:ss" )}` - : "Non expiry access" + : "Non-Expiring Access" } >