feat: resolved review comments

frontend/src/pages/secret-manager/SettingsPage/components/DeleteProjectProtection/DeleteProjectProtection.tsx

@@ -1,56 +0,0 @@
-import { createNotification } from "@app/components/notifications";
-import { ProjectPermissionCan } from "@app/components/permissions";
-import { Checkbox } from "@app/components/v2";
-import { ProjectPermissionActions, ProjectPermissionSub, useWorkspace } from "@app/context";
-import { useToggleDeleteProjectProtection } from "@app/hooks/api/workspace/queries";
-
-export const DeleteProjectProtection = () => {
-  const { currentWorkspace } = useWorkspace();
-  const { mutateAsync } = useToggleDeleteProjectProtection();
-
-  const handleToggleDeleteProjectProtection = async (state: boolean) => {
-    try {
-      if (!currentWorkspace?.id) return;
-
-      await mutateAsync({
-        workspaceID: currentWorkspace.id,
-        state
-      });
-
-      const text = `Successfully ${state ? "enabled" : "disabled"} delete protection`;
-      createNotification({
-        text,
-        type: "success"
-      });
-    } catch (err) {
-      console.error(err);
-      createNotification({
-        text: "Failed to update delete protection",
-        type: "error"
-      });
-    }
-  };
-
-  return (
-    <div className="mb-6 rounded-lg border border-mineshaft-600 bg-mineshaft-900 p-4">
-      <p className="mb-3 text-xl font-semibold">Delete Protection</p>
-      <ProjectPermissionCan I={ProjectPermissionActions.Edit} a={ProjectPermissionSub.Settings}>
-        {(isAllowed) => (
-          <div className="w-max">
-            <Checkbox
-              id="hasDeleteProtection"
-              isDisabled={!isAllowed}
-              isChecked={currentWorkspace?.hasDeleteProtection ?? false}
-              onCheckedChange={(state) => {
-                handleToggleDeleteProjectProtection(state as boolean);
-              }}
-            >
-              Protects the project from being deleted accidentally. While this option is enabled,
-              you can&apos;t delete the project.
-            </Checkbox>
-          </div>
-        )}
-      </ProjectPermissionCan>
-    </div>
-  );
-};

frontend/src/pages/secret-manager/SettingsPage/components/DeleteProjectProtection/index.tsx

@@ -1 +0,0 @@
-export { DeleteProjectProtection } from "./DeleteProjectProtection";

frontend/src/pages/secret-manager/SettingsPage/components/ProjectGeneralTab/ProjectGeneralTab.tsx

@@ -3,7 +3,6 @@ import { ProjectVersion } from "@app/hooks/api/workspace/types";
 
 import { AutoCapitalizationSection } from "../AutoCapitalizationSection";
 import { BackfillSecretReferenceSecretion } from "../BackfillSecretReferenceSection";
-import { DeleteProjectProtection } from "../DeleteProjectProtection";
 import { EnvironmentSection } from "../EnvironmentSection";
 import { PointInTimeVersionLimitSection } from "../PointInTimeVersionLimitSection";
 import { RebuildSecretIndicesSection } from "../RebuildSecretIndicesSection/RebuildSecretIndicesSection";
@@ -24,7 +23,6 @@ export const ProjectGeneralTab = () => {
       <PointInTimeVersionLimitSection />
       <BackfillSecretReferenceSecretion />
       {currentWorkspace?.version !== ProjectVersion.V3 && <RebuildSecretIndicesSection />}
-      <DeleteProjectProtection />
     </div>
   );
 };

frontend/src/pages/secret-manager/redirects/redirect-approval-page.tsx

@@ -0,0 +1,14 @@
+import { createFileRoute, redirect } from "@tanstack/react-router";
+
+// this is done as part of migration for multi product inside project
+export const Route = createFileRoute(
+  "/_authenticate/_inject-org-details/_org-layout/secret-manager/$projectId/_project-layout-fallback-approval/approval"
+)({
+  beforeLoad: ({ params, search }) => {
+    throw redirect({
+      to: "/projects/$projectId/secret-manager/approval",
+      params,
+      search
+    });
+  }
+});