awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-05 21:26:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2685 from akhilmhdh/fix/tag-no-update-in-approval

Browse Source 
fix: resolved tag update not happening via approval
This commit is contained in:
Maidul Islam
2024-11-05 09:54:13 -05:00
committed by GitHub
parent 6548372e3b 4d567f0b08
commit ea426e8b2d
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/ee/services/secret-approval-request/secret-approval-request-service.ts
+3 -2
View File
@@ -267,7 +267,8 @@ export const secretApprovalRequestServiceFactory = ({
: "", : "",
secretComment: el.secretVersion.encryptedComment secretComment: el.secretVersion.encryptedComment
? secretManagerDecryptor({ cipherTextBlob: el.secretVersion.encryptedComment }).toString() ? secretManagerDecryptor({ cipherTextBlob: el.secretVersion.encryptedComment }).toString()
: "" : "",
tags: el.secretVersion.tags
} }
: undefined : undefined
})); }));
@@ -571,7 +572,7 @@ export const secretApprovalRequestServiceFactory = ({
reminderNote: el.reminderNote, reminderNote: el.reminderNote,
skipMultilineEncoding: el.skipMultilineEncoding, skipMultilineEncoding: el.skipMultilineEncoding,
key: el.key, key: el.key,
tagIds: el?.tags.map(({ id }) => id), tags: el?.tags.map(({ id }) => id),
...encryptedValue ...encryptedValue
} }
}; };
frontend/src/views/SecretApprovalPage/components/SecretApprovalRequest/components/SecretApprovalRequestChangeItem.tsx
+2 -2
View File
@@ -96,7 +96,7 @@ export const SecretApprovalRequestChangeItem = ({
<SecretInput isReadOnly value={secretVersion?.secretValue} /> <SecretInput isReadOnly value={secretVersion?.secretValue} />
</Td> </Td>
<Td>{secretVersion?.secretComment}</Td> <Td>{secretVersion?.secretComment}</Td>
<Td> <Td className="flex flex-wrap gap-2">
{secretVersion?.tags?.map(({ slug, id: tagId, color }) => ( {secretVersion?.tags?.map(({ slug, id: tagId, color }) => (
<Tag <Tag
className="flex w-min items-center space-x-2" className="flex w-min items-center space-x-2"
@@ -118,7 +118,7 @@ export const SecretApprovalRequestChangeItem = ({
<SecretInput isReadOnly value={newVersion?.secretValue} /> <SecretInput isReadOnly value={newVersion?.secretValue} />
</Td> </Td>
<Td>{newVersion?.secretComment}</Td> <Td>{newVersion?.secretComment}</Td>
<Td> <Td className="flex flex-wrap gap-2">
{newVersion?.tags?.map(({ slug, id: tagId, color }) => ( {newVersion?.tags?.map(({ slug, id: tagId, color }) => (
<Tag <Tag
className="flex w-min items-center space-x-2" className="flex w-min items-center space-x-2"