feat: completed all layout changes needed for frontend

frontend/src/pages/secret-scanning/SecretScanningDataSourcesPage/route.tsx

@@ -1,9 +1,9 @@
-import { createFileRoute } from '@tanstack/react-router'
+import { createFileRoute } from "@tanstack/react-router";
 
-import { SecretScanningDataSourcesPage } from './SecretScanningDataSourcesPage'
+import { SecretScanningDataSourcesPage } from "./SecretScanningDataSourcesPage";
 
 export const Route = createFileRoute(
-  '/_authenticate/_inject-org-details/_org-layout/projects/secret-scanning/$projectId/_secret-scanning-layout/data-sources/',
+  "/_authenticate/_inject-org-details/_org-layout/projects/secret-scanning/$projectId/_secret-scanning-layout/data-sources/"
 )({
   component: SecretScanningDataSourcesPage,
   beforeLoad: ({ context }) => {
@@ -11,9 +11,9 @@ export const Route = createFileRoute(
       breadcrumbs: [
         ...context.breadcrumbs,
         {
-          label: 'Data Sources',
-        },
-      ],
-    }
-  },
-})
+          label: "Data Sources"
+        }
+      ]
+    };
+  }
+});

frontend/src/pages/secret-scanning/SecretScanningFindingsPage/route.tsx

@@ -1,32 +1,29 @@
-import { createFileRoute } from '@tanstack/react-router'
-import { zodValidator } from '@tanstack/zod-adapter'
-import { z } from 'zod'
+import { createFileRoute } from "@tanstack/react-router";
+import { zodValidator } from "@tanstack/zod-adapter";
+import { z } from "zod";
 
-import { SecretScanningFindingStatus } from '@app/hooks/api/secretScanningV2'
+import { SecretScanningFindingStatus } from "@app/hooks/api/secretScanningV2";
 
-import { SecretScanningFindingsPage } from './SecretScanningFindingsPage'
+import { SecretScanningFindingsPage } from "./SecretScanningFindingsPage";
 
 export const Route = createFileRoute(
-  '/_authenticate/_inject-org-details/_org-layout/projects/secret-scanning/$projectId/_secret-scanning-layout/findings',
+  "/_authenticate/_inject-org-details/_org-layout/projects/secret-scanning/$projectId/_secret-scanning-layout/findings"
 )({
   validateSearch: zodValidator(
     z.object({
       search: z.string().optional(),
-      status: z
-        .nativeEnum(SecretScanningFindingStatus)
-        .optional()
-        .catch(undefined),
-    }),
+      status: z.nativeEnum(SecretScanningFindingStatus).optional().catch(undefined)
+    })
   ),
   beforeLoad: ({ context }) => {
     return {
       breadcrumbs: [
         ...context.breadcrumbs,
         {
-          label: 'Findings',
-        },
-      ],
-    }
+          label: "Findings"
+        }
+      ]
+    };
   },
-  component: SecretScanningFindingsPage,
-})
+  component: SecretScanningFindingsPage
+});

frontend/src/pages/secret-scanning/SettingsPage/SettingsPage.tsx

@@ -10,6 +10,7 @@ import { PageHeader, Tab, TabList, TabPanel, Tabs } from "@app/components/v2";
 import { ProjectPermissionSub, useSubscription } from "@app/context";
 import { ProjectPermissionSecretScanningConfigActions } from "@app/context/ProjectPermissionContext/types";
 import { usePopUp } from "@app/hooks";
+import { ProjectGeneralTab } from "@app/pages/project/SettingsPage/components/ProjectGeneralTab";
 
 import { ProjectScanningConfigTab } from "./components/ProjectScanningConfigTab";
 
@@ -62,8 +63,12 @@ export const SettingsPage = () => {
         <Tabs defaultValue="tab-project-general">
           <TabList>
             <Tab value="tab-project-general">General</Tab>
+            <Tab value="tab-project-secret-scanning">Scanning Settings</Tab>
           </TabList>
           <TabPanel value="tab-project-general">
+            <ProjectGeneralTab />
+          </TabPanel>
+          <TabPanel value="tab-project-secret-scanning">
             <ProjectPermissionCan
               I={ProjectPermissionSecretScanningConfigActions.Read}
               a={ProjectPermissionSub.SecretScanningConfigs}

frontend/src/pages/secret-scanning/SettingsPage/route.tsx

@@ -1,9 +1,9 @@
-import { createFileRoute } from '@tanstack/react-router'
+import { createFileRoute } from "@tanstack/react-router";
 
-import { SettingsPage } from './SettingsPage'
+import { SettingsPage } from "./SettingsPage";
 
 export const Route = createFileRoute(
-  '/_authenticate/_inject-org-details/_org-layout/projects/secret-scanning/$projectId/_secret-scanning-layout/settings',
+  "/_authenticate/_inject-org-details/_org-layout/projects/secret-scanning/$projectId/_secret-scanning-layout/settings"
 )({
   component: SettingsPage,
   beforeLoad: ({ context }) => {
@@ -11,9 +11,9 @@ export const Route = createFileRoute(
       breadcrumbs: [
         ...context.breadcrumbs,
         {
-          label: 'Settings',
-        },
-      ],
-    }
-  },
-})
+          label: "Settings"
+        }
+      ]
+    };
+  }
+});