PR fix suggestions

frontend/src/components/secret-rotations-v2/forms/SecretRotationV2SecretsMappingFields/AzureClientSecretRotationSecretsMappingFields.tsx

@@ -43,6 +43,7 @@ export const AzureClientSecretRotationSecretsMappingFields = () => {
               <Input
                 value={value}
                 onChange={onChange}
+                type="password"
                 placeholder={rotationOption?.template.secretsMapping.clientSecret}
               />
             </FormControl>

frontend/src/components/secret-rotations-v2/forms/schemas/index.ts

@@ -6,10 +6,10 @@ import { MsSqlCredentialsRotationSchema } from "@app/components/secret-rotations
 import { PostgresCredentialsRotationSchema } from "@app/components/secret-rotations-v2/forms/schemas/postgres-credentials-rotation-schema";
 
 const SecretRotationUnionSchema = z.discriminatedUnion("type", [
-  PostgresCredentialsRotationSchema,
-  MsSqlCredentialsRotationSchema,
   Auth0ClientSecretRotationSchema,
-  AzureClientSecretRotationSchema
+  AzureClientSecretRotationSchema,
+  PostgresCredentialsRotationSchema,
+  MsSqlCredentialsRotationSchema
 ]);
 
 export const SecretRotationV2FormSchema = SecretRotationUnionSchema;

frontend/src/hooks/api/appConnections/types/index.ts

@@ -80,6 +80,7 @@ export type TAppConnectionMap = {
   [AppConnection.GCP]: TGcpConnection;
   [AppConnection.AzureKeyVault]: TAzureKeyVaultConnection;
   [AppConnection.AzureAppConfiguration]: TAzureAppConfigurationConnection;
+  [AppConnection.AzureClientSecrets]: TAzureClientSecretsConnection;
   [AppConnection.Databricks]: TDatabricksConnection;
   [AppConnection.Humanitec]: THumanitecConnection;
   [AppConnection.TerraformCloud]: TTerraformCloudConnection;
@@ -87,7 +88,6 @@ export type TAppConnectionMap = {
   [AppConnection.Postgres]: TPostgresConnection;
   [AppConnection.MsSql]: TMsSqlConnection;
   [AppConnection.Camunda]: TCamundaConnection;
-  [AppConnection.AzureClientSecrets]: TAzureClientSecretsConnection;
   [AppConnection.Windmill]: TWindmillConnection;
   [AppConnection.Auth0]: TAuth0Connection;
 };

frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AzureClientSecretsConnectionForm.tsx

@@ -83,15 +83,7 @@ export const AzureClientSecretsConnectionForm = ({ appConnection }: Props) => {
     }
   };
 
-  let isMissingConfig: boolean;
-
-  switch (selectedMethod) {
-    case AzureClientSecretsConnectionMethod.OAuth:
-      isMissingConfig = !oauthClientId;
-      break;
-    default:
-      throw new Error(`Unhandled Azure Connection method: ${selectedMethod}`);
-  }
+  const isMissingConfig = !oauthClientId;
 
   const methodDetails = getAppConnectionMethodDetails(selectedMethod);