From f0d19e470199fcb4abdc2aa0c1f6f2f94540281c Mon Sep 17 00:00:00 2001
From: Scott Wilson <scottraywilson@gmail.com>
Date: Fri, 8 Nov 2024 09:29:42 -0800
Subject: [PATCH] fix: handle tag select overflow for create secret modal.
 minor text revisions.

---
 frontend/src/views/SecretMainPage/SecretMainPage.tsx       | 5 +++--
 .../components/CreateSecretForm/CreateSecretForm.tsx       | 4 ++--
 .../src/views/SecretOverviewPage/SecretOverviewPage.tsx    | 7 ++++---
 .../components/CreateSecretForm/CreateSecretForm.tsx       | 4 ++--
 4 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/frontend/src/views/SecretMainPage/SecretMainPage.tsx b/frontend/src/views/SecretMainPage/SecretMainPage.tsx
index 31427d67c..31635884c 100644
--- a/frontend/src/views/SecretMainPage/SecretMainPage.tsx
+++ b/frontend/src/views/SecretMainPage/SecretMainPage.tsx
@@ -538,8 +538,9 @@ const SecretMainPageContent = () => {
             onOpenChange={(state) => togglePopUp(PopUpNames.CreateSecretForm, state)}
           >
             <ModalContent
-              title="Create secret"
-              subTitle="Add a secret to the particular environment and folder"
+              title="Create Secret"
+              subTitle="Add a secret to this particular environment and folder"
+              bodyClassName="overflow-visible"
             >
               <CreateSecretForm
                 environment={environment}
diff --git a/frontend/src/views/SecretMainPage/components/CreateSecretForm/CreateSecretForm.tsx b/frontend/src/views/SecretMainPage/components/CreateSecretForm/CreateSecretForm.tsx
index 611ba440e..b8a49053d 100644
--- a/frontend/src/views/SecretMainPage/components/CreateSecretForm/CreateSecretForm.tsx
+++ b/frontend/src/views/SecretMainPage/components/CreateSecretForm/CreateSecretForm.tsx
@@ -141,7 +141,7 @@ export const CreateSecretForm = ({
               !canReadTags ? (
                 <div className="flex items-center space-x-2">
                   <FontAwesomeIcon icon={faTriangleExclamation} className="text-yellow-400" />
-                  <span>User lacks permission to read tags. Please grant access.</span>
+                  <span>You do not have permission to read tags.</span>
                 </div>
               ) : (
                 ""
@@ -150,7 +150,7 @@ export const CreateSecretForm = ({
           >
             <MultiSelect
               className="w-full"
-              placeholder="Choose tags to assign to secrets."
+              placeholder="Select tags to assign to secret..."
               isMulti
               name="tagIds"
               isDisabled={!canReadTags}
diff --git a/frontend/src/views/SecretOverviewPage/SecretOverviewPage.tsx b/frontend/src/views/SecretOverviewPage/SecretOverviewPage.tsx
index 0571f63c4..ec5b064c1 100644
--- a/frontend/src/views/SecretOverviewPage/SecretOverviewPage.tsx
+++ b/frontend/src/views/SecretOverviewPage/SecretOverviewPage.tsx
@@ -1121,9 +1121,10 @@ export const SecretOverviewPage = () => {
         onOpenChange={(isOpen) => handlePopUpToggle("addSecretsInAllEnvs", isOpen)}
       >
         <ModalContent
-          className="max-h-[80vh] overflow-y-auto"
-          title="Bulk Create & Update"
-          subTitle="Create & update a secret across many environments"
+          className="max-h-[80vh]"
+          bodyClassName="overflow-visible"
+          title="Create Secrets"
+          subTitle="Create a secret across multiple environments"
         >
           <CreateSecretForm
             secretPath={secretPath}
diff --git a/frontend/src/views/SecretOverviewPage/components/CreateSecretForm/CreateSecretForm.tsx b/frontend/src/views/SecretOverviewPage/components/CreateSecretForm/CreateSecretForm.tsx
index 1d4ce1af0..4f675a099 100644
--- a/frontend/src/views/SecretOverviewPage/components/CreateSecretForm/CreateSecretForm.tsx
+++ b/frontend/src/views/SecretOverviewPage/components/CreateSecretForm/CreateSecretForm.tsx
@@ -242,7 +242,7 @@ export const CreateSecretForm = ({ secretPath = "/", getSecretByKey, onClose }:
               !canReadTags ? (
                 <div className="flex items-center space-x-2">
                   <FontAwesomeIcon icon={faTriangleExclamation} className="text-yellow-400" />
-                  <span>User lacks permission to read tags. Please grant access.</span>
+                  <span>You do not have permission to read tags.</span>
                 </div>
               ) : (
                 ""
@@ -251,7 +251,7 @@ export const CreateSecretForm = ({ secretPath = "/", getSecretByKey, onClose }:
           >
             <MultiSelect
               className="w-full"
-              placeholder="Choose tags to assign to secrets."
+              placeholder="Select tags to assign to secrets..."
               isMulti
               name="tagIds"
               isDisabled={!canReadTags}