refactor: streamline async logic and notification handling across various settings and integration components

frontend/src/pages/secret-manager/IntegrationsListPage/components/NativeIntegrationsTab/NativeIntegrationsTab.tsx

@@ -108,27 +108,18 @@ export const NativeIntegrationsTab = () => {
     shouldDeleteIntegrationSecrets: boolean,
     cb: () => void
   ) => {
-    try {
     await deleteIntegration({ id: integrationId, workspaceId, shouldDeleteIntegrationSecrets });
     if (cb) cb();
     createNotification({
       type: "success",
       text: "Deleted integration"
     });
-    } catch (err) {
-      console.log(err);
-      createNotification({
-        type: "error",
-        text: "Failed to delete integration"
-      });
-    }
   };
 
   const handleIntegrationAuthRevoke = async (provider: string, cb?: () => void) => {
     const integrationAuthForProvider = integrationAuths?.[provider];
     if (!integrationAuthForProvider) return;
 
-    try {
     await deleteIntegrationAuths({
       integration: provider,
       workspaceId
@@ -138,13 +129,6 @@ export const NativeIntegrationsTab = () => {
       type: "success",
       text: "Revoked provider authentication"
     });
-    } catch (err) {
-      console.error(err);
-      createNotification({
-        type: "error",
-        text: "Failed to revoke provider authentication"
-      });
-    }
   };
 
   const { popUp, handlePopUpOpen, handlePopUpClose, handlePopUpToggle } = usePopUp([

frontend/src/pages/secret-manager/SettingsPage/components/EnvironmentSection/EnvironmentSection.tsx

@@ -39,7 +39,6 @@ export const EnvironmentSection = () => {
   ] as const);
 
   const onEnvDeleteSubmit = async (id: string) => {
-    try {
     if (!currentProject?.id) return;
 
     await deleteWsEnvironment.mutateAsync({
@@ -53,13 +52,6 @@ export const EnvironmentSection = () => {
     });
 
     handlePopUpClose("deleteEnv");
-    } catch (err) {
-      console.error(err);
-      createNotification({
-        text: "Failed to delete environment",
-        type: "error"
-      });
-    }
   };
 
   return (

frontend/src/pages/secret-manager/SettingsPage/components/EnvironmentSection/EnvironmentTable.tsx

@@ -46,7 +46,6 @@ export const EnvironmentTable = ({ handlePopUpOpen }: Props) => {
   const updateEnvironment = useUpdateWsEnvironment();
 
   const handleReorderEnv = async (id: string, position: number) => {
-    try {
     if (!currentProject?.id) return;
 
     await updateEnvironment.mutateAsync({
@@ -59,13 +58,6 @@ export const EnvironmentTable = ({ handlePopUpOpen }: Props) => {
       text: "Successfully re-ordered environments",
       type: "success"
     });
-    } catch (err) {
-      console.error(err);
-      createNotification({
-        text: "Failed to re-order environments",
-        type: "error"
-      });
-    }
   };
 
   const isMoreEnvironmentsAllowed =

frontend/src/pages/secret-manager/SettingsPage/components/SecretDetectionIgnoreValuesSection/SecretDetectionIgnoreValuesSection.tsx

@@ -55,7 +55,6 @@ export const SecretDetectionIgnoreValuesSection = () => {
   }, [currentProject?.secretDetectionIgnoreValues, reset]);
 
   const handleIgnoreValuesSubmit = async ({ ignoreValues }: TForm) => {
-    try {
     await updateProject({
       projectId: currentProject.id,
       secretDetectionIgnoreValues: ignoreValues.map((item) => item.value)
@@ -65,12 +64,6 @@ export const SecretDetectionIgnoreValuesSection = () => {
       text: "Successfully updated secret detection ignore values",
       type: "success"
     });
-    } catch {
-      createNotification({
-        text: "Failed updating secret detection ignore values",
-        type: "error"
-      });
-    }
   };
 
   const isAdmin = hasProjectRole(ProjectMembershipRole.Admin);

frontend/src/pages/secret-manager/SettingsPage/components/SecretSnapshotsLegacySection/SecretSnapshotsLegacySection.tsx

@@ -30,12 +30,6 @@ export const SecretSnapshotsLegacySection = () => {
         text: `Successfully ${state ? "enabled" : "disabled"} secret snapshots legacy for this project`,
         type: "success"
       });
-    } catch (err) {
-      console.error(err);
-      createNotification({
-        text: "Failed to update secret snapshots legacy for this project",
-        type: "error"
-      });
     } finally {
       setIsLoading(false);
     }

frontend/src/pages/secret-manager/SettingsPage/components/WebhooksTab/WebhooksTab.tsx

@@ -59,7 +59,6 @@ export const WebhooksTab = withProjectPermission(
     const { mutateAsync: deleteWebhook } = useDeleteWebhook();
 
     const handleWebhookCreate = async (data: TFormSchema) => {
-      try {
       await createWebhook({
         ...data,
         projectId
@@ -69,17 +68,9 @@ export const WebhooksTab = withProjectPermission(
         type: "success",
         text: "Successfully created webhook"
       });
-      } catch (err) {
-        console.log(err);
-        createNotification({
-          type: "error",
-          text: "Failed to create webhook"
-        });
-      }
     };
 
     const handleWebhookDisable = async (webhookId: string, isDisabled: boolean) => {
-      try {
       await updateWebhook({
         webhookId,
         projectId,
@@ -89,17 +80,9 @@ export const WebhooksTab = withProjectPermission(
         type: "success",
         text: "Successfully updated webhook"
       });
-      } catch (err) {
-        console.log(err);
-        createNotification({
-          type: "error",
-          text: "Failed to update webhook"
-        });
-      }
     };
 
     const handleWebhookDelete = async () => {
-      try {
       const webhookId = popUp?.deleteWebhook?.data as string;
       await deleteWebhook({
         webhookId,
@@ -110,17 +93,9 @@ export const WebhooksTab = withProjectPermission(
         type: "success",
         text: "Successfully deleted webhook"
       });
-      } catch (err) {
-        console.log(err);
-        createNotification({
-          type: "error",
-          text: "Failed to delete webhook"
-        });
-      }
     };
 
     const handleWebhookTest = async (webhookId: string) => {
-      try {
       await testWebhook({
         webhookId,
         projectId
@@ -129,13 +104,6 @@ export const WebhooksTab = withProjectPermission(
         type: "success",
         text: "Successfully triggered webhook"
       });
-      } catch (err) {
-        console.log(err);
-        createNotification({
-          type: "error",
-          text: "Failed to trigger webhook"
-        });
-      }
     };
 
     return (

frontend/src/pages/secret-manager/SettingsPage/components/WorkflowIntegrationSection/components/MicrosoftTeamsIntegrationForm.tsx

@@ -130,7 +130,6 @@ export const MicrosoftTeamsIntegrationForm = ({ onClose }: Props) => {
   });
 
   const handleIntegrationSave = async (data: TMicrosoftTeamsConfigForm) => {
-    try {
     if (!currentProject) {
       return;
     }
@@ -155,12 +154,6 @@ export const MicrosoftTeamsIntegrationForm = ({ onClose }: Props) => {
     });
 
     onClose();
-    } catch {
-      createNotification({
-        type: "error",
-        text: "Failed to create microsoft teams integration"
-      });
-    }
   };
 
   const selectedAccessRequestTeamId = watch("accessRequestChannels.teamId");

frontend/src/pages/secret-scanning/SecretScanningDataSourceByIdPage/components/SecretScanningResourceSection.tsx

@@ -22,7 +22,6 @@ export const SecretScanningResourceSection = ({ dataSource }: Props) => {
   const triggerDataSourceScan = useTriggerSecretScanningDataSource();
 
   const handleTriggerScan = async () => {
-    try {
     await triggerDataSourceScan.mutateAsync({
       dataSourceId: dataSource.id,
       type: dataSource.type,
@@ -33,12 +32,6 @@ export const SecretScanningResourceSection = ({ dataSource }: Props) => {
       text: `Successfully triggered scan for ${dataSource.name}`,
       type: "success"
     });
-    } catch {
-      createNotification({
-        text: `Failed to trigger scan for ${dataSource.name}`,
-        type: "error"
-      });
-    }
   };
 
   const resourceDetails = RESOURCE_DESCRIPTION_HELPER[dataSource.type];

frontend/src/pages/secret-scanning/SecretScanningDataSourcesPage/components/SecretScanningDataSourcesTable.tsx

@@ -184,7 +184,6 @@ export const SecretScanningDataSourcesTable = ({ dataSources }: Props) => {
 
     const isAutoScanEnabled = !dataSource.isAutoScanEnabled;
 
-    try {
     await updateDataSource.mutateAsync({
       dataSourceId: dataSource.id,
       type: dataSource.type,
@@ -196,16 +195,9 @@ export const SecretScanningDataSourcesTable = ({ dataSources }: Props) => {
       text: `Successfully ${isAutoScanEnabled ? "enabled" : "disabled"} auto-scan for ${destinationName} Data Source`,
       type: "success"
     });
-    } catch {
-      createNotification({
-        text: `Failed to ${isAutoScanEnabled ? "enable" : "disable"} auto-scan for ${destinationName} Data Source`,
-        type: "error"
-      });
-    }
   };
 
   const handleTriggerScan = async (dataSource: TSecretScanningDataSource) => {
-    try {
     await triggerDataSourceScan.mutateAsync({
       dataSourceId: dataSource.id,
       type: dataSource.type,
@@ -216,12 +208,6 @@ export const SecretScanningDataSourcesTable = ({ dataSources }: Props) => {
       text: "Successfully triggered scan",
       type: "success"
     });
-    } catch {
-      createNotification({
-        text: "Failed to trigger scan",
-        type: "error"
-      });
-    }
   };
 
   return (

frontend/src/pages/ssh/SettingsPage/components/ProjectSshTab/components/ProjectSshConfigCasSection.tsx

@@ -47,7 +47,6 @@ export const ProjectSshConfigCasSection = () => {
   }, [sshConfig]);
 
   const onFormSubmit = async ({ defaultUserSshCaId, defaultHostSshCaId }: FormData) => {
-    try {
     await updateProjectSshConfig({
       projectId: currentProject.id,
       defaultUserSshCaId: defaultUserSshCaId || undefined,
@@ -58,13 +57,6 @@ export const ProjectSshConfigCasSection = () => {
       text: "Successfully updated SSH project settings",
       type: "success"
     });
-    } catch (err) {
-      console.error(err);
-      createNotification({
-        text: "Failed to update SSH project settings",
-        type: "error"
-      });
-    }
   };
 
   return (

frontend/src/pages/ssh/SshCaByIDPage/SshCaByIDPage.tsx

@@ -43,7 +43,6 @@ const Page = () => {
   ] as const);
 
   const onRemoveCaSubmit = async (caIdToDelete: string) => {
-    try {
     if (!projectId) return;
 
     await deleteSshCa({ caId: caIdToDelete });
@@ -60,13 +59,6 @@ const Page = () => {
         projectId
       }
     });
-    } catch (err) {
-      console.error(err);
-      createNotification({
-        text: "Failed to delete SSH CA",
-        type: "error"
-      });
-    }
   };
 
   return (

frontend/src/pages/ssh/SshCaByIDPage/components/SshCertificateModal.tsx

@@ -122,7 +122,6 @@ export const SshCertificateModal = ({ popUp, handlePopUpToggle }: Props) => {
     ttl,
     keyId
   }: FormData) => {
-    try {
     if (!templateData) return;
     if (!projectId) return;
 
@@ -174,13 +173,6 @@ export const SshCertificateModal = ({ popUp, handlePopUpToggle }: Props) => {
       text: "Successfully created SSH certificate",
       type: "success"
     });
-    } catch (err) {
-      console.error(err);
-      createNotification({
-        text: "Failed to create SSH certificate",
-        type: "error"
-      });
-    }
   };
 
   return (

frontend/src/pages/ssh/SshCaByIDPage/components/SshCertificateTemplateModal.tsx

@@ -138,7 +138,6 @@ export const SshCertificateTemplateModal = ({ popUp, handlePopUpToggle, sshCaId
     allowedHosts,
     allowCustomKeyIds
   }: FormData) => {
-    try {
     if (certTemplate) {
       await updateSshCertTemplate({
         id: certTemplate.id,
@@ -177,13 +176,6 @@ export const SshCertificateTemplateModal = ({ popUp, handlePopUpToggle, sshCaId
 
     reset();
     handlePopUpToggle("sshCertificateTemplate", false);
-    } catch (err) {
-      console.error(err);
-      createNotification({
-        text: "Failed to save changes",
-        type: "error"
-      });
-    }
   };
 
   return (

frontend/src/pages/ssh/SshCaByIDPage/components/SshCertificateTemplatesSection.tsx

@@ -33,24 +33,16 @@ export const SshCertificateTemplatesSection = ({ caId }: Props) => {
   const { mutateAsync: updateSshCertTemplate } = useUpdateSshCertTemplate();
 
   const onRemoveSshCertificateTemplateSubmit = async (id: string) => {
-    try {
     await deleteSshCertTemplate({
       id
     });
 
-      await createNotification({
+    createNotification({
       text: "Successfully deleted SSH certificate template",
       type: "success"
     });
 
     handlePopUpClose("deleteSshCertificateTemplate");
-    } catch (err) {
-      console.error(err);
-      createNotification({
-        text: "Failed to delete SSH certificate template",
-        type: "error"
-      });
-    }
   };
 
   const onUpdateSshCaStatus = async ({
@@ -60,10 +52,9 @@ export const SshCertificateTemplatesSection = ({ caId }: Props) => {
     templateId: string;
     status: SshCertTemplateStatus;
   }) => {
-    try {
     await updateSshCertTemplate({ id: templateId, status });
 
-      await createNotification({
+    createNotification({
       text: `Successfully ${
         status === SshCertTemplateStatus.ACTIVE ? "enabled" : "disabled"
       } SSH certificate template`,
@@ -71,15 +62,6 @@ export const SshCertificateTemplatesSection = ({ caId }: Props) => {
     });
 
     handlePopUpClose("sshCertificateTemplateStatus");
-    } catch (err) {
-      console.error(err);
-      createNotification({
-        text: `Failed to ${
-          status === SshCertTemplateStatus.ACTIVE ? "enabled" : "disabled"
-        } SSH certificate template`,
-        type: "error"
-      });
-    }
   };
 
   return (

frontend/src/pages/ssh/SshCasPage/components/SshCaModal.tsx

@@ -106,7 +106,6 @@ export const SshCaModal = ({ popUp, handlePopUpToggle }: Props) => {
     publicKey,
     privateKey
   }: FormData) => {
-    try {
     if (!projectId) return;
 
     if (ca) {
@@ -140,13 +139,6 @@ export const SshCaModal = ({ popUp, handlePopUpToggle }: Props) => {
       text: `Successfully ${ca ? "updated" : "created"} SSH CA`,
       type: "success"
     });
-    } catch (err) {
-      console.error(err);
-      createNotification({
-        text: `Failed to ${ca ? "update" : "create"} SSH CA`,
-        type: "error"
-      });
-    }
   };
 
   return (

frontend/src/pages/ssh/SshCasPage/components/SshCaSection.tsx

@@ -23,7 +23,6 @@ export const SshCaSection = () => {
   ] as const);
 
   const onRemoveSshCaSubmit = async (caId: string) => {
-    try {
     await deleteSshCa({ caId });
 
     createNotification({
@@ -32,17 +31,9 @@ export const SshCaSection = () => {
     });
 
     handlePopUpClose("deleteSshCa");
-    } catch (err) {
-      console.error(err);
-      createNotification({
-        text: "Failed to delete SSH CA",
-        type: "error"
-      });
-    }
   };
 
   const onUpdateSshCaStatus = async ({ caId, status }: { caId: string; status: SshCaStatus }) => {
-    try {
     await updateSshCa({ caId, status });
 
     createNotification({
@@ -51,13 +42,6 @@ export const SshCaSection = () => {
     });
 
     handlePopUpClose("sshCaStatus");
-    } catch (err) {
-      console.error(err);
-      createNotification({
-        text: `Failed to ${status === SshCaStatus.ACTIVE ? "enabled" : "disabled"} SSH CA`,
-        type: "error"
-      });
-    }
   };
 
   return (

frontend/src/pages/ssh/SshHostGroupDetailsByIDPage/SshHostGroupDetailsByIDPage.tsx

@@ -44,7 +44,6 @@ const Page = () => {
   ] as const);
 
   const onRemoveSshGroupSubmit = async (groupIdToDelete: string) => {
-    try {
     if (!projectId) return;
 
     await deleteSshHostGroup({ sshHostGroupId: groupIdToDelete });
@@ -61,13 +60,6 @@ const Page = () => {
         projectId
       }
     });
-    } catch (err) {
-      console.error(err);
-      createNotification({
-        text: "Failed to delete SSH group",
-        type: "error"
-      });
-    }
   };
 
   return (

frontend/src/pages/ssh/SshHostGroupDetailsByIDPage/components/AddHostGroupMemberModal.tsx

@@ -42,7 +42,6 @@ export const AddHostGroupMemberModal = ({ popUp, handlePopUpToggle }: Props) =>
     useAddHostToSshHostGroup();
 
   const handleAddHost = async (sshHostId: string) => {
-    try {
     if (!popUpData?.sshHostGroupId) {
       createNotification({
         text: "Some data is missing, please refresh the page and try again",
@@ -60,12 +59,6 @@ export const AddHostGroupMemberModal = ({ popUp, handlePopUpToggle }: Props) =>
       text: "Successfully added host to the group",
       type: "success"
     });
-    } catch {
-      createNotification({
-        text: "Failed to add host to the group",
-        type: "error"
-      });
-    }
   };
 
   return (

frontend/src/pages/ssh/SshHostsPage/components/SshHostGroupModal.tsx

@@ -121,7 +121,6 @@ export const SshHostGroupModal = ({ popUp, handlePopUpToggle }: Props) => {
   }, [sshHostGroup]);
 
   const onFormSubmit = async ({ name, loginMappings }: FormData) => {
-    try {
     if (!projectId) return;
 
     // check if there is already a different host group with the same name
@@ -175,13 +174,6 @@ export const SshHostGroupModal = ({ popUp, handlePopUpToggle }: Props) => {
       text: `Successfully ${sshHostGroup ? "updated" : "created"} SSH host group`,
       type: "success"
     });
-    } catch (err) {
-      console.error(err);
-      createNotification({
-        text: `Failed to ${sshHostGroup ? "update" : "create"} SSH host group`,
-        type: "error"
-      });
-    }
   };
 
   const toggleMapping = (index: number) => {

frontend/src/pages/ssh/SshHostsPage/components/SshHostsSection.tsx

@@ -20,7 +20,6 @@ export const SshHostsSection = () => {
   ] as const);
 
   const onRemoveSshHostSubmit = async (sshHostId: string) => {
-    try {
     const host = await deleteSshHost({ sshHostId });
 
     createNotification({
@@ -29,13 +28,6 @@ export const SshHostsSection = () => {
     });
 
     handlePopUpClose("deleteSshHost");
-    } catch (err) {
-      console.error(err);
-      createNotification({
-        text: "Failed to delete SSH host",
-        type: "error"
-      });
-    }
   };
 
   return (

frontend/src/pages/user/PersonalSettingsPage/components/APIKeySection/APIKeyTable.tsx

@@ -22,19 +22,11 @@ export const APIKeyTable = () => {
   const { mutateAsync } = useDeleteAPIKey();
 
   const handleDeleteAPIKeyDataClick = async (apiKeyDataId: string) => {
-    try {
     await mutateAsync(apiKeyDataId);
     createNotification({
       text: "Successfully deleted API key",
       type: "success"
     });
-    } catch (err) {
-      console.error(err);
-      createNotification({
-        text: "Failed to delete API key",
-        type: "error"
-      });
-    }
   };
 
   return (

frontend/src/pages/user/PersonalSettingsPage/components/APIKeySection/AddAPIKeyModal.tsx

@@ -76,7 +76,6 @@ export const AddAPIKeyModal = ({ popUp, handlePopUpToggle }: Props) => {
   };
 
   const onFormSubmit = async ({ name, expiresIn }: FormData) => {
-    try {
     const { apiKey } = await mutateAsync({
       name,
       expiresIn: expirationMapping[expiresIn]
@@ -90,13 +89,6 @@ export const AddAPIKeyModal = ({ popUp, handlePopUpToggle }: Props) => {
     });
 
     reset();
-    } catch (err) {
-      console.error(err);
-      createNotification({
-        text: "Failed to create API key",
-        type: "error"
-      });
-    }
   };
 
   const hasAPIKey = Boolean(newAPIKey);