feat(secrets-ui): improve types and code quality

This commit is contained in:
carlosmonastyrski
2025-04-25 18:17:33 -03:00
parent 4160009913
commit f345801bd6
5 changed files with 10 additions and 9 deletions
@@ -1073,8 +1073,8 @@ export const ActionBar = ({
onChange={(isOpen) => handlePopUpToggle("bulkDeleteSecrets", isOpen)}
onDeleteApproved={handleSecretBulkDelete}
formContent={
importedBy &&
importedBy.length > 0 && (
((importedBy && importedBy.length > 0) ||
(usedBySecretSyncs && usedBySecretSyncs?.length > 0)) && (
<CollapsibleSecretImports
importedBy={importedBy}
secretsToDelete={Object.values(selectedSecrets).map((s) => s.key)}
@@ -66,7 +66,8 @@ export const CollapsibleSecretImports: React.FC<CollapsibleSecretImportsProps> =
if (item.type === ItemType.SecretSync) {
window.open(
`/secret-manager/${currentWorkspace.id}/integrations?selectedTab=secret-syncs`,
"_blank"
"_blank",
"noopener,noreferrer"
);
return;
}
@@ -208,14 +208,14 @@ export const SecretItem = memo(
};
const handleFormSubmit = async (data: TFormSchema) => {
if (
const hasDirectReferences =
importedBy &&
importedBy.some(({ folders }) =>
folders?.some(({ secrets }) =>
secrets?.some(({ referencedSecretId }) => referencedSecretId === secret.id)
)
)
) {
);
if (hasDirectReferences) {
handlePopUpOpen("editSecret", data);
return;
}