awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-07 10:27:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolved permission check on imported secrets when using service token

Browse Source
This commit is contained in:
Akhil Mohan
2023-10-03 20:14:43 +05:30
parent bd8c17d720
commit f3908e6b2a
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/controllers/v3/secretsController.ts
+3 -5
View File
@@ -3,7 +3,7 @@ import { Types } from "mongoose";
import { EventService, SecretService } from "../../services"; import { EventService, SecretService } from "../../services";
import { eventPushSecrets } from "../../events"; import { eventPushSecrets } from "../../events";
import { BotService } from "../../services"; import { BotService } from "../../services";
import { containsGlobPatterns, isValidScope, repackageSecretToRaw } from "../../helpers/secrets"; import { containsGlobPatterns, repackageSecretToRaw } from "../../helpers/secrets";
import { encryptSymmetric128BitHexKeyUTF8 } from "../../utils/crypto"; import { encryptSymmetric128BitHexKeyUTF8 } from "../../utils/crypto";
import { getAllImportedSecrets } from "../../services/SecretImportService"; import { getAllImportedSecrets } from "../../services/SecretImportService";
import { Folder, IServiceTokenData } from "../../models"; import { Folder, IServiceTokenData } from "../../models";
@@ -81,8 +81,7 @@ export const getSecretsRaw = async (req: Request, res: Response) => {
secretPath, secretPath,
requiredPermissions: [PERMISSION_READ_SECRETS] requiredPermissions: [PERMISSION_READ_SECRETS]
}); });
permissionCheckFn = (env: string, secPath: string) => permissionCheckFn = () => true;
isValidScope(req.authData.authPayload as IServiceTokenData, env, secPath);
} }
const secrets = await SecretService.getSecrets({ const secrets = await SecretService.getSecrets({
@@ -447,8 +446,7 @@ export const getSecrets = async (req: Request, res: Response) => {
secretPath, secretPath,
requiredPermissions: [PERMISSION_READ_SECRETS] requiredPermissions: [PERMISSION_READ_SECRETS]
}); });
permissionCheckFn = (env: string, secPath: string) => permissionCheckFn = () => true;
isValidScope(req.authData.authPayload as IServiceTokenData, env, secPath);
} }
const secrets = await SecretService.getSecrets({ const secrets = await SecretService.getSecrets({