diff --git a/.env.example b/.env.example index 23f845b71..53e36449a 100644 --- a/.env.example +++ b/.env.example @@ -107,6 +107,10 @@ INF_APP_CONNECTION_GITHUB_APP_PRIVATE_KEY= INF_APP_CONNECTION_GITHUB_APP_SLUG= INF_APP_CONNECTION_GITHUB_APP_ID= +#gitlab app connection +INF_APP_CONNECTION_GITLAB_OAUTH_CLIENT_ID= +INF_APP_CONNECTION_GITLAB_OAUTH_CLIENT_SECRET= + #github radar app connection INF_APP_CONNECTION_GITHUB_RADAR_APP_CLIENT_ID= INF_APP_CONNECTION_GITHUB_RADAR_APP_CLIENT_SECRET= diff --git a/docs/integrations/app-connections/gitlab.mdx b/docs/integrations/app-connections/gitlab.mdx index 6401630a1..62728882e 100644 --- a/docs/integrations/app-connections/gitlab.mdx +++ b/docs/integrations/app-connections/gitlab.mdx @@ -97,8 +97,8 @@ Infisical supports two methods for connecting to GitLab: **OAuth** and **Access - - For Secret Rotations, your token will require the ability to access the API: + + For Secret Syncs, your token will require the ability to access the API: Fill in the token details: - **Token name**: A descriptive name for the token (e.g., "connection-token") - **Expiration date**: Set an appropriate expiration date @@ -107,6 +107,10 @@ Infisical supports two methods for connecting to GitLab: **OAuth** and **Access ![GitLab Personal Token Form](/images/app-connections/gitlab/gitlab-personal-access-token-form.png) + + + Personal Access Token connections require manual token rotation when your GitLab access token expires or is regenerated. Monitor your connection status and update the token as needed. + Copy the generated token immediately as it won't be shown again. @@ -131,8 +135,8 @@ Infisical supports two methods for connecting to GitLab: **OAuth** and **Access - - For Secret Rotations, your token will require the ability to access the API and be at least an **Owner**: + + For Secret Syncs, your token will require the ability to access the API and be at least an **Owner**: Fill in the token details: - **Token name**: A descriptive name for the token - **Expiration date**: Set an appropriate expiration date @@ -144,7 +148,7 @@ Infisical supports two methods for connecting to GitLab: **OAuth** and **Access - Access Token connections require manual token rotation when your GitLab access token expires or is regenerated. Monitor your connection status and update the token as needed. + Project Access Token connections require manual token rotation when your GitLab access token expires or is regenerated. Monitor your connection status and update the token as needed. @@ -172,7 +176,7 @@ Infisical supports two methods for connecting to GitLab: **OAuth** and **Access ![Select GitLab Connection](/images/app-connections/gitlab/select-gitlab-connection.png) - Select the **Access Token** method and paste your GitLab access token in the provided field. And select the appropriate token type. + Select the **Access Token** method, paste your GitLab access token in the provided field, and select the appropriate token type. ![Configure Access Token](/images/app-connections/gitlab/create-gitlab-access-token-connection.png) diff --git a/docs/self-hosting/configuration/envars.mdx b/docs/self-hosting/configuration/envars.mdx index 6f3dffa77..f5d1c58d0 100644 --- a/docs/self-hosting/configuration/envars.mdx +++ b/docs/self-hosting/configuration/envars.mdx @@ -489,10 +489,10 @@ When set, all visits to the Infisical login page will automatically redirect use Follow detailed guide to configure [GitLab SSO](/documentation/platform/sso/gitlab) - + OAuth2 client ID for GitLab login - + OAuth2 client secret for GitLab login @@ -591,11 +591,11 @@ You can configure third-party app connections for re-use across Infisical Projec - + The Application ID of your GitLab OAuth application. - + The Secret of your GitLab OAuth application. diff --git a/frontend/src/pages/organization/AppConnections/OauthCallbackPage/OauthCallbackPage.tsx b/frontend/src/pages/organization/AppConnections/OauthCallbackPage/OauthCallbackPage.tsx index bf227737d..4a09ac93f 100644 --- a/frontend/src/pages/organization/AppConnections/OauthCallbackPage/OauthCallbackPage.tsx +++ b/frontend/src/pages/organization/AppConnections/OauthCallbackPage/OauthCallbackPage.tsx @@ -516,7 +516,6 @@ export const OAuthCallbackPage = () => { (async () => { let data: { connectionId?: string; returnUrl?: string; appConnectionName?: string } | null = null; - console.log("appConnection", appConnection); if (appConnection === AppConnection.GitHub) { data = await handleGithub();