From f5d769fa05886a73e6d346836ed8e432efe0f53d Mon Sep 17 00:00:00 2001
From: = <akhilmhdh@gmail.com>
Date: Mon, 23 Jun 2025 23:37:51 +0530
Subject: [PATCH] feat: addressed review  comments

---
 .../dynamic-secret-lease/dynamic-secret-lease-queue.ts | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/backend/src/ee/services/dynamic-secret-lease/dynamic-secret-lease-queue.ts b/backend/src/ee/services/dynamic-secret-lease/dynamic-secret-lease-queue.ts
index 503e19632..93c3dd147 100644
--- a/backend/src/ee/services/dynamic-secret-lease/dynamic-secret-lease-queue.ts
+++ b/backend/src/ee/services/dynamic-secret-lease/dynamic-secret-lease-queue.ts
@@ -64,6 +64,7 @@ export const dynamicSecretLeaseQueueServiceFactory = ({
   };
 
   const unsetLeaseRevocation = async (leaseId: string) => {
+    await queueService.stopJobById(QueueName.DynamicSecretRevocation, leaseId);
     await queueService.stopJobByIdPg(QueueName.DynamicSecretRevocation, leaseId);
   };
 
@@ -169,6 +170,7 @@ export const dynamicSecretLeaseQueueServiceFactory = ({
       if (error instanceof DisableRotationErrors) {
         if (jobId) {
           await queueService.stopRepeatableJobByJobId(QueueName.DynamicSecretRevocation, jobId);
+          await queueService.stopJobByIdPg(QueueName.DynamicSecretRevocation, jobId);
         }
       }
       // propogate to next part
@@ -187,8 +189,8 @@ export const dynamicSecretLeaseQueueServiceFactory = ({
         await $dynamicSecretQueueJob(job.name, job.id, job.data);
       },
       {
-        workerCount: 2,
-        pollingIntervalSeconds: 30
+        workerCount: 5,
+        pollingIntervalSeconds: 1
       }
     );
 
@@ -198,8 +200,8 @@ export const dynamicSecretLeaseQueueServiceFactory = ({
         await $dynamicSecretQueueJob(job.name, job.id, job.data);
       },
       {
-        workerCount: 2,
-        pollingIntervalSeconds: 5
+        workerCount: 1,
+        pollingIntervalSeconds: 1
       }
     );
   };