From f9c936865ab783991609d52dd1bfe55b9c259129 Mon Sep 17 00:00:00 2001
From: carlosmonastyrski <charly.monastyrski@gmail.com>
Date: Mon, 28 Apr 2025 16:49:29 -0300
Subject: [PATCH] feat(secrets-ui): minor improvements from PR suggestions

---
 .../SecretOverviewTableRow/SecretEditRow.tsx  | 55 ++++++-------------
 .../components/SecretListView/SecretItem.tsx  | 16 ------
 .../SecretListView/SecretListView.tsx         |  2 -
 3 files changed, 18 insertions(+), 55 deletions(-)

diff --git a/frontend/src/pages/secret-manager/OverviewPage/components/SecretOverviewTableRow/SecretEditRow.tsx b/frontend/src/pages/secret-manager/OverviewPage/components/SecretOverviewTableRow/SecretEditRow.tsx
index 6d21ca6e1..ffbad9412 100644
--- a/frontend/src/pages/secret-manager/OverviewPage/components/SecretOverviewTableRow/SecretEditRow.tsx
+++ b/frontend/src/pages/secret-manager/OverviewPage/components/SecretOverviewTableRow/SecretEditRow.tsx
@@ -87,7 +87,6 @@ export const SecretEditRow = ({
   const { permission } = useProjectPermission();
 
   const [isDeleting, setIsDeleting] = useToggle();
-  const [isSecretBlurFocus, setIsSecretBlurFocus] = useToggle(false);
   const [isModalOpen, setIsModalOpen] = useState<boolean>(false);
 
   const toggleModal = useCallback(() => {
@@ -129,7 +128,6 @@ export const SecretEditRow = ({
       setTimeout(() => {
         reset({ value: defaultValue || null });
       }, 50);
-      setIsSecretBlurFocus.off();
     } else {
       reset({ value });
     }
@@ -150,12 +148,6 @@ export const SecretEditRow = ({
     })
   );
 
-  const handleSecretBlurClick = () => {
-    if (canEditSecretValue) {
-      setIsSecretBlurFocus.toggle();
-    }
-  };
-
   const handleDeleteSecret = useCallback(async () => {
     setIsDeleting.on();
     setIsModalOpen(false);
@@ -185,35 +177,24 @@ export const SecretEditRow = ({
         </Tooltip>
       )}
       <div className="flex-grow border-r border-r-mineshaft-600 pl-1 pr-2">
-        {secretValueHidden && !isSecretBlurFocus ? (
-          // eslint-disable-next-line jsx-a11y/click-events-have-key-events, jsx-a11y/no-static-element-interactions
-          <div className="flex flex-grow items-center gap-2" onClick={handleSecretBlurClick}>
-            <span className="flex flex-row items-center">
-              <div style={{ fontFamily: "monospace" }} className="h-full w-full">
-                ******
-              </div>
-            </span>
-          </div>
-        ) : (
-          <Controller
-            disabled={isImportedSecret && !defaultValue}
-            control={control}
-            name="value"
-            render={({ field }) => (
-              <InfisicalSecretInput
-                {...field}
-                isReadOnly={isImportedSecret || isRotatedSecret}
-                value={field.value as string}
-                key="secret-input"
-                isVisible={isVisible && !secretValueHidden}
-                secretPath={secretPath}
-                environment={environment}
-                isImport={isImportedSecret}
-                defaultValue={secretValueHidden ? "" : undefined}
-              />
-            )}
-          />
-        )}
+        <Controller
+          disabled={isImportedSecret && !defaultValue}
+          control={control}
+          name="value"
+          render={({ field }) => (
+            <InfisicalSecretInput
+              {...field}
+              isReadOnly={isImportedSecret || isRotatedSecret}
+              value={field.value as string}
+              key="secret-input"
+              isVisible={isVisible && !secretValueHidden}
+              secretPath={secretPath}
+              environment={environment}
+              isImport={isImportedSecret}
+              defaultValue={secretValueHidden ? "" : undefined}
+            />
+          )}
+        />
       </div>
 
       <div
diff --git a/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretItem.tsx b/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretItem.tsx
index d717fecae..65d001e95 100644
--- a/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretItem.tsx
+++ b/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretItem.tsx
@@ -95,7 +95,6 @@ export const SecretItem = memo(
     const { currentWorkspace } = useWorkspace();
     const { permission } = useProjectPermission();
     const { isRotatedSecret } = secret;
-    const [isSecretBlurFocus, setIsSecretBlurFocus] = useToggle(false);
 
     const canEditSecretValue = permission.can(
       ProjectPermissionSecretActions.Edit,
@@ -189,12 +188,6 @@ export const SecretItem = memo(
       overrideAction === SecretActionType.Created || overrideAction === SecretActionType.Modified;
     const hasTagsApplied = Boolean(fields.length);
 
-    const handleSecretBlurClick = () => {
-      if (canEditSecretValue) {
-        setIsSecretBlurFocus.toggle();
-      }
-    };
-
     const handleOverrideClick = () => {
       if (isOverriden) {
         // override need not be flagged delete if it was never saved in server
@@ -334,15 +327,6 @@ export const SecretItem = memo(
                     />
                   )}
                 />
-              ) : secretValueHidden && !isSecretBlurFocus ? (
-                // eslint-disable-next-line jsx-a11y/click-events-have-key-events, jsx-a11y/no-static-element-interactions
-                <div className="flex flex-grow items-center gap-2" onClick={handleSecretBlurClick}>
-                  <span className="flex flex-row items-center">
-                    <div style={{ fontFamily: "monospace" }} className="h-full w-full">
-                      {hiddenValue}
-                    </div>
-                  </span>
-                </div>
               ) : (
                 <Controller
                   name="value"
diff --git a/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretListView.tsx b/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretListView.tsx
index 5c70b91e4..1ef2c7076 100644
--- a/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretListView.tsx
+++ b/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretListView.tsx
@@ -49,8 +49,6 @@ export const SecretListView = ({
   isProtectedBranch = false,
   importedBy
 }: Props) => {
-  console.log("secretssssss", secrets);
-
   const queryClient = useQueryClient();
   const { popUp, handlePopUpToggle, handlePopUpOpen, handlePopUpClose } = usePopUp([
     "deleteSecret",