From fe97a77f9bae3936624b296374ff716a024ad2b4 Mon Sep 17 00:00:00 2001 From: Carlos Monastyrski Date: Wed, 19 Nov 2025 21:00:05 -0300 Subject: [PATCH] Remove import certificates option not supported yet --- .../aws-secrets-manager-pki-sync-fns.ts | 76 +------------------ backend/src/services/pki-sync/pki-sync-fns.ts | 7 +- 2 files changed, 2 insertions(+), 81 deletions(-) diff --git a/backend/src/services/pki-sync/aws-secrets-manager/aws-secrets-manager-pki-sync-fns.ts b/backend/src/services/pki-sync/aws-secrets-manager/aws-secrets-manager-pki-sync-fns.ts index cb4227ad1..11e52ec7e 100644 --- a/backend/src/services/pki-sync/aws-secrets-manager/aws-secrets-manager-pki-sync-fns.ts +++ b/backend/src/services/pki-sync/aws-secrets-manager/aws-secrets-manager-pki-sync-fns.ts @@ -3,7 +3,6 @@ import { CreateSecretCommand, DeleteSecretCommand, - GetSecretValueCommand, ListSecretsCommand, SecretsManagerClient, UpdateSecretCommand @@ -553,82 +552,9 @@ export const awsSecretsManagerPkiSyncFactory = ({ return { removed, failed }; }; - const importCertificates = async (pkiSync: TPkiSyncWithCredentials): Promise => { - const awsPkiSync = pkiSync as unknown as TAwsSecretsManagerPkiSyncWithCredentials; - const client = await getSecretsManagerClient(awsPkiSync); - - const existingSecrets = await $getSecretsManagerSecrets(awsPkiSync, pkiSync.id); - const certificateMap: TCertificateMap = {}; - - const syncOptions = pkiSync.syncOptions as - | { - fieldMappings?: { - certificate?: string; - privateKey?: string; - certificateChain?: string; - caCertificate?: string; - }; - } - | undefined; - const fieldMappings = { - certificate: syncOptions?.fieldMappings?.certificate ?? "certificate", - privateKey: syncOptions?.fieldMappings?.privateKey ?? "private_key", - certificateChain: syncOptions?.fieldMappings?.certificateChain ?? "certificate_chain", - caCertificate: syncOptions?.fieldMappings?.caCertificate ?? "ca_certificate" - }; - - for (const [secretName] of Object.entries(existingSecrets)) { - try { - const secretValueResult = await withRateLimitRetry( - () => - client.send( - new GetSecretValueCommand({ - SecretId: secretName - }) - ), - { - operation: "get-secret-value", - syncId: pkiSync.id - } - ); - - if (secretValueResult.SecretString) { - const secretData = JSON.parse(secretValueResult.SecretString) as AwsSecretsManagerCertificateSecret; - - const cert = secretData[fieldMappings.certificate]; - const privateKey = secretData[fieldMappings.privateKey]; - const certificateChain = secretData[fieldMappings.certificateChain]; - const caCertificate = secretData[fieldMappings.caCertificate]; - - if (typeof cert === "string" && typeof privateKey === "string") { - certificateMap[secretName] = { - cert, - privateKey, - certificateChain: typeof certificateChain === "string" ? certificateChain : undefined, - caCertificate: typeof caCertificate === "string" ? caCertificate : undefined, - certificateId: secretName - }; - } - } - } catch (error) { - logger.error( - { - secretName, - error: parseErrorMessage(error), - pkiSyncId: pkiSync.id - }, - "Failed to import certificate from secret" - ); - } - } - - return certificateMap; - }; - return { syncCertificates, - removeCertificates, - importCertificates + removeCertificates }; }; diff --git a/backend/src/services/pki-sync/pki-sync-fns.ts b/backend/src/services/pki-sync/pki-sync-fns.ts index 1d91a582d..169cb328f 100644 --- a/backend/src/services/pki-sync/pki-sync-fns.ts +++ b/backend/src/services/pki-sync/pki-sync-fns.ts @@ -184,12 +184,7 @@ export const PkiSyncFns = { ); } case PkiSync.AwsSecretsManager: { - checkPkiSyncDestination(pkiSync, PkiSync.AwsSecretsManager as PkiSync); - const awsSecretsManagerPkiSync = awsSecretsManagerPkiSyncFactory({ - certificateDAL: dependencies.certificateDAL, - certificateSyncDAL: dependencies.certificateSyncDAL - }); - return awsSecretsManagerPkiSync.importCertificates(pkiSync); + throw new Error("AWS Secrets Manager does not support importing certificates into Infisical"); } case PkiSync.Chef: { throw new Error(