awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-04 06:26:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1869 from Infisical/misc/made-aws-sm-mapping-plaintext-one-to-one

Browse Source 
misc: made aws sm mapping one to one plaintext
This commit is contained in:
Sheen Capadngan
2024-05-24 02:15:04 +08:00
committed by GitHub
parent 0bc778b9bf e7c5645aa9
commit 049df6abec
1 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/services/integration-auth/integration-sync-secret.ts
+14 -10
View File
@@ -587,7 +587,10 @@ const syncSecretsAWSSecretManager = async ({
} }
}); });
const processAwsSecret = async (secretId: string, keyValuePairs: Record<string, string | null | undefined>) => { const processAwsSecret = async (
secretId: string,
secretValue: Record<string, string | null | undefined> | string
) => {
try { try {
const awsSecretManagerSecret = await secretsManager.send( const awsSecretManagerSecret = await secretsManager.send(
new GetSecretValueCommand({ new GetSecretValueCommand({
@@ -595,17 +598,20 @@ const syncSecretsAWSSecretManager = async ({
}) })
); );
let awsSecretManagerSecretObj: { [key: string]: AWS.SecretsManager } = {}; let secretToCompare;
if (awsSecretManagerSecret?.SecretString) { if (awsSecretManagerSecret?.SecretString) {
awsSecretManagerSecretObj = JSON.parse(awsSecretManagerSecret.SecretString); if (typeof secretValue === "string") {
secretToCompare = awsSecretManagerSecret.SecretString;
} else {
secretToCompare = JSON.parse(awsSecretManagerSecret.SecretString);
}
} }
if (!isEqual(awsSecretManagerSecretObj, keyValuePairs)) { if (!isEqual(secretToCompare, secretValue)) {
await secretsManager.send( await secretsManager.send(
new UpdateSecretCommand({ new UpdateSecretCommand({
SecretId: secretId, SecretId: secretId,
SecretString: JSON.stringify(keyValuePairs) SecretString: typeof secretValue === "string" ? secretValue : JSON.stringify(secretValue)
}) })
); );
} }
@@ -695,7 +701,7 @@ const syncSecretsAWSSecretManager = async ({
await secretsManager.send( await secretsManager.send(
new CreateSecretCommand({ new CreateSecretCommand({
Name: secretId, Name: secretId,
SecretString: JSON.stringify(keyValuePairs), SecretString: typeof secretValue === "string" ? secretValue : JSON.stringify(secretValue),
...(metadata.kmsKeyId && { KmsKeyId: metadata.kmsKeyId }), ...(metadata.kmsKeyId && { KmsKeyId: metadata.kmsKeyId }),
Tags: metadata.secretAWSTag Tags: metadata.secretAWSTag
? metadata.secretAWSTag.map((tag: { key: string; value: string }) => ({ Key: tag.key, Value: tag.value })) ? metadata.secretAWSTag.map((tag: { key: string; value: string }) => ({ Key: tag.key, Value: tag.value }))
@@ -708,9 +714,7 @@ const syncSecretsAWSSecretManager = async ({
if (metadata.mappingBehavior === IntegrationMappingBehavior.ONE_TO_ONE) { if (metadata.mappingBehavior === IntegrationMappingBehavior.ONE_TO_ONE) {
for await (const [key, value] of Object.entries(secrets)) { for await (const [key, value] of Object.entries(secrets)) {
await processAwsSecret(key, { await processAwsSecret(key, value.value);
[key]: value.value
});
} }
} else { } else {
await processAwsSecret(integration.app as string, getSecretKeyValuePair(secrets)); await processAwsSecret(integration.app as string, getSecretKeyValuePair(secrets));