awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-09-22 13:39:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(slack-integration): improve channel handling by filtering empty values and update Microsoft Teams badge status

Browse Source
This commit is contained in:
Victor Santos
2025-10-27 09:44:09 -03:00
parent c1dc3c2b76
commit 16cf4a91c0
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
backend/src/lib/workflow-integrations/notification-handlers/slack.ts
View File

@@ -25,15 +25,15 @@ const handleSlackNotification = async ({
switch (notification.type) {
case TriggerFeature.ACCESS_REQUEST:
case TriggerFeature.ACCESS_REQUEST_UPDATED:
targetChannelIds = slackConfig.accessRequestChannels?.split(", ") || [];
targetChannelIds = slackConfig.accessRequestChannels?.split(", ").filter(Boolean) || [];
isEnabled = slackConfig.isAccessRequestNotificationEnabled;
break;
case TriggerFeature.SECRET_APPROVAL:
targetChannelIds = slackConfig.secretRequestChannels?.split(", ") || [];
targetChannelIds = slackConfig.secretRequestChannels?.split(", ").filter(Boolean) || [];
isEnabled = slackConfig.isSecretRequestNotificationEnabled;
break;
case TriggerFeature.SECRET_SYNC_ERROR:
targetChannelIds = slackConfig.secretSyncErrorChannels?.split(", ") || [];
targetChannelIds = slackConfig.secretSyncErrorChannels?.split(", ").filter(Boolean) || [];
isEnabled = slackConfig.isSecretSyncErrorNotificationEnabled;
break;
default:

2
frontend/src/pages/secret-manager/SettingsPage/components/WorkflowIntegrationSection/components/MicrosoftTeamsConfigRow.tsx
View File

@@ -93,7 +93,7 @@ export const MicrosoftTeamsConfigRow = ({
)}
</Td>
<Td>
<Badge variant="danger">Coming Soon</Badge>
<Badge variant="danger">Disabled</Badge>
</Td>
<Td>
<DropdownMenu>

6
frontend/src/pages/secret-manager/SettingsPage/components/WorkflowIntegrationSection/components/SlackIntegrationForm.tsx
View File

@@ -141,19 +141,19 @@ export const SlackIntegrationForm = ({ onClose }: Props) => {
if (slackChannels) {
setValue(
"secretRequestChannels",
slackConfig.secretRequestChannels
(slackConfig.secretRequestChannels || "")
.split(", ")
.filter((channel) => channel in slackChannelIdToName)
);
setValue(
"accessRequestChannels",
slackConfig.accessRequestChannels
(slackConfig.accessRequestChannels || "")
.split(", ")
.filter((channel) => channel in slackChannelIdToName)
);
setValue(
"secretSyncErrorChannels",
slackConfig.secretSyncErrorChannels
(slackConfig.secretSyncErrorChannels || "")
.split(", ")
.filter((channel) => channel in slackChannelIdToName)
);