awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-02 20:25:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(slack-integration): improve channel handling by filtering empty values and update Microsoft Teams badge status

Browse Source
This commit is contained in:
Victor Santos
2025-10-27 09:44:09 -03:00
parent c1dc3c2b76
commit 16cf4a91c0
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/lib/workflow-integrations/notification-handlers/slack.ts
+3 -3
View File
@@ -25,15 +25,15 @@ const handleSlackNotification = async ({
switch (notification.type) { switch (notification.type) {
case TriggerFeature.ACCESS_REQUEST: case TriggerFeature.ACCESS_REQUEST:
case TriggerFeature.ACCESS_REQUEST_UPDATED: case TriggerFeature.ACCESS_REQUEST_UPDATED:
targetChannelIds = slackConfig.accessRequestChannels?.split(", ") || []; targetChannelIds = slackConfig.accessRequestChannels?.split(", ").filter(Boolean) || [];
isEnabled = slackConfig.isAccessRequestNotificationEnabled; isEnabled = slackConfig.isAccessRequestNotificationEnabled;
break; break;
case TriggerFeature.SECRET_APPROVAL: case TriggerFeature.SECRET_APPROVAL:
targetChannelIds = slackConfig.secretRequestChannels?.split(", ") || []; targetChannelIds = slackConfig.secretRequestChannels?.split(", ").filter(Boolean) || [];
isEnabled = slackConfig.isSecretRequestNotificationEnabled; isEnabled = slackConfig.isSecretRequestNotificationEnabled;
break; break;
case TriggerFeature.SECRET_SYNC_ERROR: case TriggerFeature.SECRET_SYNC_ERROR:
targetChannelIds = slackConfig.secretSyncErrorChannels?.split(", ") || []; targetChannelIds = slackConfig.secretSyncErrorChannels?.split(", ").filter(Boolean) || [];
isEnabled = slackConfig.isSecretSyncErrorNotificationEnabled; isEnabled = slackConfig.isSecretSyncErrorNotificationEnabled;
break; break;
default: default:
frontend/src/pages/secret-manager/SettingsPage/components/WorkflowIntegrationSection/components/MicrosoftTeamsConfigRow.tsx
+1 -1
View File
@@ -93,7 +93,7 @@ export const MicrosoftTeamsConfigRow = ({
)} )}
</Td> </Td>
<Td> <Td>
<Badge variant="danger">Coming Soon</Badge> <Badge variant="danger">Disabled</Badge>
</Td> </Td>
<Td> <Td>
<DropdownMenu> <DropdownMenu>
frontend/src/pages/secret-manager/SettingsPage/components/WorkflowIntegrationSection/components/SlackIntegrationForm.tsx
+3 -3
View File
@@ -141,19 +141,19 @@ export const SlackIntegrationForm = ({ onClose }: Props) => {
if (slackChannels) { if (slackChannels) {
setValue( setValue(
"secretRequestChannels", "secretRequestChannels",
slackConfig.secretRequestChannels (slackConfig.secretRequestChannels || "")
.split(", ") .split(", ")
.filter((channel) => channel in slackChannelIdToName) .filter((channel) => channel in slackChannelIdToName)
); );
setValue( setValue(
"accessRequestChannels", "accessRequestChannels",
slackConfig.accessRequestChannels (slackConfig.accessRequestChannels || "")
.split(", ") .split(", ")
.filter((channel) => channel in slackChannelIdToName) .filter((channel) => channel in slackChannelIdToName)
); );
setValue( setValue(
"secretSyncErrorChannels", "secretSyncErrorChannels",
slackConfig.secretSyncErrorChannels (slackConfig.secretSyncErrorChannels || "")
.split(", ") .split(", ")
.filter((channel) => channel in slackChannelIdToName) .filter((channel) => channel in slackChannelIdToName)
); );