awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-09-22 13:39:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

throw only error and remove bool return

Browse Source
This commit is contained in:
Maidul Islam
2025-04-28 07:55:33 -04:00
parent 694ab35f53
commit 1dfc9511c1
3 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
backend/src/ee/services/external-kms/providers/aws-kms.ts
View File

@@ -107,10 +107,8 @@ export const AwsKmsProviderFactory = async ({ inputs }: AwsKmsProviderArgs): Pro
const cleanup = async () => {
try {
awsClient.destroy();
return true;
} catch (error) {
logger.error(error, "cleanup: failed to destroy AWS KMS client");
return false;
throw new Error("Failed to cleanup AWS KMS client", { cause: error });
}
};

4
backend/src/ee/services/external-kms/providers/gcp-kms.ts
View File

@@ -48,10 +48,8 @@ export const GcpKmsProviderFactory = async ({ inputs }: GcpKmsProviderArgs): Pro
const cleanup = async () => {
try {
await gcpKmsClient.close();
return true;
} catch (error) {
logger.error(error, "cleanup: failed to close GCP KMS client");
return false;
throw new Error("Failed to cleanup GCP KMS client", { cause: error });
}
};

2
backend/src/ee/services/external-kms/providers/model.ts
View File

@@ -98,5 +98,5 @@ export type TExternalKmsProviderFns = {
validateConnection: () => Promise<boolean>;
encrypt: (data: Buffer) => Promise<{ encryptedBlob: Buffer }>;
decrypt: (encryptedBlob: Buffer) => Promise<{ data: Buffer }>;
cleanup: () => Promise<boolean>;
cleanup: () => Promise<void>;
};