awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-09-22 13:39:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix linter error

Browse Source
This commit is contained in:
Fang-Pen Lin
2025-11-20 17:28:54 -08:00
parent 7c477ef027
commit 2b19425cc7
1 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
backend/src/services/certificate-authority/internal/internal-certificate-authority-service.ts
View File

@@ -1719,15 +1719,17 @@ export const internalCertificateAuthorityServiceFactory = ({
const dn = parseDistinguishedName(csrObj.subject);
let cn = commonName || dn.commonName;
if ((allowEmptyCommonName ?? false) && !cn) {
// Notice: for modern TLS certificates, the CN is deprecated, many ACME clients will generate CSRs with without a CN
// we allow empty CN here to support ACME clients mostly. Since it's unclear what's the side effect of
// allowing empty CN for legacy PKI code, let's only do it if a true allowEmptyCommonName value is provided.
cn = "";
} else if (!cn) {
throw new BadRequestError({
message: "A common name (CN) is required in the CSR or as a parameter to this endpoint"
});
if (!cn) {
if (allowEmptyCommonName ?? false) {
// Notice: for modern TLS certificates, the CN is deprecated, many ACME clients will generate CSRs with without a CN
// we allow empty CN here to support ACME clients mostly. Since it's unclear what's the side effect of
// allowing empty CN for legacy PKI code, let's only do it if a true allowEmptyCommonName value is provided.
cn = "";
} else {
throw new BadRequestError({
message: "A common name (CN) is required in the CSR or as a parameter to this endpoint"
});
}
}
const { caPrivateKey, caSecret } = await getCaCredentials({
@@ -1946,7 +1948,7 @@ export const internalCertificateAuthorityServiceFactory = ({
certificateTemplateId: certificateTemplate?.id,
status: CertStatus.ACTIVE,
friendlyName: friendlyName || csrObj.subject,
commonName: cn,
commonName: cn!,
altNames: altNamesFromCsr || altNames,
serialNumber,
notBefore: notBeforeDate,