fix(secrets-permissions): UI improvements

This commit is contained in:
carlosmonastyrski
2025-04-24 08:10:10 -03:00
parent 95489e1b0a
commit 350272aa57
4 changed files with 10 additions and 7 deletions

View File

@@ -93,6 +93,7 @@ export const SecretInput = forwardRef<HTMLTextAreaElement, Props>(
onFocus={(evt) => {
onFocus?.(evt);
setIsSecretFocused.on();
evt.currentTarget.select();
}}
disabled={isDisabled}
spellCheck={false}

View File

@@ -179,7 +179,7 @@ export const SecretEditRow = ({
/>
{secretValueHidden && (
<Tooltip
content={`You do not have permission to read the value of this secret.${canEditSecretValue ? " But you can edit this secret" : ""}`}
content={`You do not have access to view the current value${canEditSecretValue ? ", but you can set a new one" : "."}`}
>
<FontAwesomeIcon className="pl-1" icon={faEyeSlash} />
</Tooltip>
@@ -190,7 +190,7 @@ export const SecretEditRow = ({
<div className="flex flex-grow items-center gap-2" onClick={handleSecretBlurClick}>
<span className="flex flex-row items-center">
<div style={{ fontFamily: "monospace" }} className="h-full w-full">
*********************
******
</div>
</span>
</div>

View File

@@ -87,7 +87,7 @@ export const SecretOverviewTableRow = ({
);
if (secret?.secretValueHidden) {
return canEditSecretValue ? "<hidden-by-infisical>" : "";
return canEditSecretValue ? "******" : "";
}
return secret?.valueOverride || secret?.value || importedSecret?.secret?.value || "";
};

View File

@@ -56,6 +56,8 @@ import {
TFormSchema
} from "./SecretListView.utils";
const hiddenValue = "******";
type Props = {
secret: SecretV3RawSanitized;
onSaveSecret: (
@@ -107,7 +109,7 @@ export const SecretItem = memo(
const getDefaultValue = () => {
if (secret.secretValueHidden) {
return canEditSecretValue ? "<hidden-by-infisical>" : "";
return canEditSecretValue ? hiddenValue : "";
}
return secret.valueOverride || secret.value || "";
};
@@ -312,7 +314,7 @@ export const SecretItem = memo(
>
{secretValueHidden && (
<Tooltip
content={`You do not have permission to read the value of this secret.${canEditSecretValue ? " But you can edit this secret" : ""}`}
content={`You do not have access to view the current value${canEditSecretValue ? ", but you can set a new one" : "."}`}
>
<FontAwesomeIcon className="pr-2" icon={faEyeSlash} />
</Tooltip>
@@ -337,7 +339,7 @@ export const SecretItem = memo(
<div className="flex flex-grow items-center gap-2" onClick={handleSecretBlurClick}>
<span className="flex flex-row items-center">
<div style={{ fontFamily: "monospace" }} className="h-full w-full">
*********************
{hiddenValue}
</div>
</span>
</div>
@@ -354,7 +356,7 @@ export const SecretItem = memo(
environment={environment}
secretPath={secretPath}
{...field}
defaultValue={secretValueHidden ? "<hidden-by-infisical>" : undefined}
defaultValue={secretValueHidden ? hiddenValue : undefined}
containerClassName="py-1.5 rounded-md transition-all"
/>
)}