Fix for secrets reminder modal, now saving the reminder on modal close

This commit is contained in:
carlosmonastyrski
2025-03-03 16:13:03 -03:00
parent c29841fbcf
commit 3fa450b9a7
2 changed files with 12 additions and 4 deletions

View File

@@ -192,6 +192,10 @@ export const SecretDetailSidebar = ({
await onSaveSecret(secret, { ...secret, ...data }, () => reset());
};
const handleReminderSubmit = async (reminderRepeatDays: number | null, reminderNote: string | null) => {
await onSaveSecret(secret, { ...secret, reminderRepeatDays, reminderNote, isReminderEvent: true }, () => {});
}
const [createReminderFormOpen, setCreateReminderFormOpen] = useToggle(false);
const secretReminderRepeatDays = watch("reminderRepeatDays");
@@ -207,8 +211,9 @@ export const SecretDetailSidebar = ({
setCreateReminderFormOpen.toggle();
if (data) {
setValue("reminderRepeatDays", data.days, { shouldDirty: true });
setValue("reminderNote", data.note, { shouldDirty: true });
setValue("reminderRepeatDays", data.days, { shouldDirty: false });
setValue("reminderNote", data.note, { shouldDirty: false });
handleReminderSubmit(data.days, data.note)
}
}}
/>

View File

@@ -158,7 +158,8 @@ export const SecretListView = ({
comment,
reminderRepeatDays,
reminderNote,
secretMetadata
secretMetadata,
isReminderEvent
} = modSecret;
const hasKeyChanged = oldKey !== key && key;
@@ -234,7 +235,9 @@ export const SecretListView = ({
queryClient.invalidateQueries({
queryKey: secretApprovalRequestKeys.count({ workspaceId })
});
handlePopUpClose("secretDetail");
if (!isReminderEvent) {
handlePopUpClose("secretDetail");
}
createNotification({
type: isProtectedBranch && !personalAction ? "info" : "success",
text: