awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-06 21:27:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for secrets reminder modal, now saving the reminder on modal close

Browse Source
This commit is contained in:
carlosmonastyrski
2025-03-03 16:13:03 -03:00
parent c29841fbcf
commit 3fa450b9a7
2 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretDetailSidebar.tsx
+7 -2
View File
@@ -192,6 +192,10 @@ export const SecretDetailSidebar = ({
await onSaveSecret(secret, { ...secret, ...data }, () => reset()); await onSaveSecret(secret, { ...secret, ...data }, () => reset());
}; };
const handleReminderSubmit = async (reminderRepeatDays: number | null, reminderNote: string | null) => {
await onSaveSecret(secret, { ...secret, reminderRepeatDays, reminderNote, isReminderEvent: true }, () => {});
}
const [createReminderFormOpen, setCreateReminderFormOpen] = useToggle(false); const [createReminderFormOpen, setCreateReminderFormOpen] = useToggle(false);
const secretReminderRepeatDays = watch("reminderRepeatDays"); const secretReminderRepeatDays = watch("reminderRepeatDays");
@@ -207,8 +211,9 @@ export const SecretDetailSidebar = ({
setCreateReminderFormOpen.toggle(); setCreateReminderFormOpen.toggle();
if (data) { if (data) {
setValue("reminderRepeatDays", data.days, { shouldDirty: true }); setValue("reminderRepeatDays", data.days, { shouldDirty: false });
setValue("reminderNote", data.note, { shouldDirty: true }); setValue("reminderNote", data.note, { shouldDirty: false });
handleReminderSubmit(data.days, data.note)
} }
}} }}
/> />
frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretListView.tsx
+4 -1
View File
@@ -158,7 +158,8 @@ export const SecretListView = ({
comment, comment,
reminderRepeatDays, reminderRepeatDays,
reminderNote, reminderNote,
secretMetadata secretMetadata,
isReminderEvent
} = modSecret; } = modSecret;
const hasKeyChanged = oldKey !== key && key; const hasKeyChanged = oldKey !== key && key;
@@ -234,7 +235,9 @@ export const SecretListView = ({
queryClient.invalidateQueries({ queryClient.invalidateQueries({
queryKey: secretApprovalRequestKeys.count({ workspaceId }) queryKey: secretApprovalRequestKeys.count({ workspaceId })
}); });
if (!isReminderEvent) {
handlePopUpClose("secretDetail"); handlePopUpClose("secretDetail");
}
createNotification({ createNotification({
type: isProtectedBranch && !personalAction ? "info" : "success", type: isProtectedBranch && !personalAction ? "info" : "success",
text: text: