feat: resolved nits

This commit is contained in:
=
2025-02-01 01:55:49 +05:30
parent 1d57629036
commit 757942aefc
5 changed files with 9 additions and 9 deletions
@@ -165,7 +165,7 @@ export const groupServiceFactory = ({
if (!permissionBoundary.isValid) if (!permissionBoundary.isValid)
throw new ForbiddenRequestError({ throw new ForbiddenRequestError({
name: "PermissionBoundaryError", name: "PermissionBoundaryError",
message: "Failed to create a more privileged group", message: "Failed to update a more privileged group",
details: { missingPermissions: permissionBoundary.missingPermissions } details: { missingPermissions: permissionBoundary.missingPermissions }
}); });
if (isCustomRole) customRole = customOrgRole; if (isCustomRole) customRole = customOrgRole;
+1 -1
View File
@@ -29,7 +29,7 @@ const isOperatorsASubset = (parentSet: TPermissionConditionShape, subset: TPermi
// we compute each operator against each other in left hand side and right hand side // we compute each operator against each other in left hand side and right hand side
if (subset[PermissionConditionOperators.$EQ] || subset[PermissionConditionOperators.$NEQ]) { if (subset[PermissionConditionOperators.$EQ] || subset[PermissionConditionOperators.$NEQ]) {
const subsetOperatorValue = subset[PermissionConditionOperators.$EQ] || subset[PermissionConditionOperators.$NEQ]; const subsetOperatorValue = subset[PermissionConditionOperators.$EQ] || subset[PermissionConditionOperators.$NEQ];
const isInverted = Boolean(subset[PermissionConditionOperators.$NEQ]); const isInverted = !subset[PermissionConditionOperators.$EQ];
if ( if (
parentSet[PermissionConditionOperators.$EQ] && parentSet[PermissionConditionOperators.$EQ] &&
invertTheOperation(isInverted, parentSet[PermissionConditionOperators.$EQ] !== subsetOperatorValue) invertTheOperation(isInverted, parentSet[PermissionConditionOperators.$EQ] !== subsetOperatorValue)
@@ -95,7 +95,7 @@ export const identityProjectServiceFactory = ({
if (!permissionBoundary.isValid) if (!permissionBoundary.isValid)
throw new ForbiddenRequestError({ throw new ForbiddenRequestError({
name: "PermissionBoundaryError", name: "PermissionBoundaryError",
message: "Failed to change to a more privileged role", message: "Failed to assign to a more privileged role",
details: { missingPermissions: permissionBoundary.missingPermissions } details: { missingPermissions: permissionBoundary.missingPermissions }
}); });
} }
@@ -287,7 +287,7 @@ export const identityProjectServiceFactory = ({
if (!permissionBoundary.isValid) if (!permissionBoundary.isValid)
throw new ForbiddenRequestError({ throw new ForbiddenRequestError({
name: "PermissionBoundaryError", name: "PermissionBoundaryError",
message: "Failed to delete more privileged identity", message: "Failed to remove more privileged identity",
details: { missingPermissions: permissionBoundary.missingPermissions } details: { missingPermissions: permissionBoundary.missingPermissions }
}); });
@@ -421,7 +421,7 @@ export const identityUaServiceFactory = ({
if (!permissionBoundary.isValid) if (!permissionBoundary.isValid)
throw new ForbiddenRequestError({ throw new ForbiddenRequestError({
name: "PermissionBoundaryError", name: "PermissionBoundaryError",
message: "Failed to add identity to project with more privileged role", message: "Failed to create client secret for a more privileged identity.",
details: { missingPermissions: permissionBoundary.missingPermissions } details: { missingPermissions: permissionBoundary.missingPermissions }
}); });
@@ -484,7 +484,7 @@ export const identityUaServiceFactory = ({
if (!permissionBoundary.isValid) if (!permissionBoundary.isValid)
throw new ForbiddenRequestError({ throw new ForbiddenRequestError({
name: "PermissionBoundaryError", name: "PermissionBoundaryError",
message: "Failed to get identity with more privileged role", message: "Failed to get identity client secret with more privileged role",
details: { missingPermissions: permissionBoundary.missingPermissions } details: { missingPermissions: permissionBoundary.missingPermissions }
}); });
@@ -536,7 +536,7 @@ export const identityUaServiceFactory = ({
if (!permissionBoundary.isValid) if (!permissionBoundary.isValid)
throw new ForbiddenRequestError({ throw new ForbiddenRequestError({
name: "PermissionBoundaryError", name: "PermissionBoundaryError",
message: "Failed to read identity client secret of project with more privileged role", message: "Failed to read identity client secret of identity with more privileged role",
details: { missingPermissions: permissionBoundary.missingPermissions } details: { missingPermissions: permissionBoundary.missingPermissions }
}); });
@@ -137,7 +137,7 @@ export const identityServiceFactory = ({
if (!permissionBoundary.isValid) if (!permissionBoundary.isValid)
throw new ForbiddenRequestError({ throw new ForbiddenRequestError({
name: "PermissionBoundaryError", name: "PermissionBoundaryError",
message: "Failed to delete a more privileged identity", message: "Failed to update a more privileged identity",
details: { missingPermissions: permissionBoundary.missingPermissions } details: { missingPermissions: permissionBoundary.missingPermissions }
}); });
@@ -232,7 +232,7 @@ export const identityServiceFactory = ({
if (!permissionBoundary.isValid) if (!permissionBoundary.isValid)
throw new ForbiddenRequestError({ throw new ForbiddenRequestError({
name: "PermissionBoundaryError", name: "PermissionBoundaryError",
message: "Failed to delete more privileged user", message: "Failed to delete more privileged identity",
details: { missingPermissions: permissionBoundary.missingPermissions } details: { missingPermissions: permissionBoundary.missingPermissions }
}); });