Enhance InfisicalSecretInput to use wildcard for environment and secret tags; update error message to reflect resource type. Improve tooltip in CreateSecretForm for secret references in both Overview and SecretDashboard pages.

This commit is contained in:
Victor Santos
2025-11-07 12:58:52 -03:00
parent 299e3065d5
commit 782776e9de
3 changed files with 32 additions and 8 deletions

View File

@@ -337,10 +337,10 @@ export const InfisicalSecretInput = forwardRef<HTMLTextAreaElement, Props>(
permission,
ProjectPermissionSecretActions.ReadValue,
{
environment: propEnvironment ?? "",
environment: propEnvironment ?? "*",
secretPath: propSecretPath ?? "/",
secretName: segment,
secretTags: []
secretTags: ["*"]
}
);
@@ -395,14 +395,21 @@ export const InfisicalSecretInput = forwardRef<HTMLTextAreaElement, Props>(
{
environment: environmentSlug,
secretPath,
secretName: secretName ?? "",
secretTags: []
secretName: secretName ?? "*",
secretTags: ["*"]
}
);
let resourceName = "secret";
if (segment === environmentSlug) {
resourceName = "environment";
} else if (segment !== secretName && folderPath.includes(segment)) {
resourceName = "folder";
}
if (!canReadSecretValue) {
createNotification({
text: "You do not have permission to access this secret",
text: `You do not have permission to access this ${resourceName}`,
type: "error"
});
return;

View File

@@ -255,10 +255,12 @@ export const CreateSecretForm = ({ secretPath = "/", onClose }: Props) => {
<code>
&#36;{"{"}secret_name{"}"}
</code>
.
<br />
<br /> You can go to the referenced secret by holding the <code>Cmd</code> (Mac) or{" "}
<code>Ctrl</code> (Windows/Linux) key and clicking on the secret name.
<br />
You can go to the referenced secret by holding the{" "}
<code className="rounded-sm bg-mineshaft-600 p-0.5">Cmd</code> (Mac) or{" "}
<code className="rounded-sm bg-mineshaft-600 p-0.5">Ctrl</code> (Windows/Linux) key
and clicking on the secret name.
</div>
}
tooltipClassName="max-w-md"

View File

@@ -197,6 +197,21 @@ export const CreateSecretForm = ({
render={({ field }) => (
<FormControl
label="Value"
tooltipText={
<div>
You can add references to other secrets using the format{" "}
<code>
&#36;{"{"}secret_name{"}"}
</code>
<br />
<br />
You can go to the referenced secret by holding the{" "}
<code className="rounded-sm bg-mineshaft-600 p-0.5">Cmd</code> (Mac) or{" "}
<code className="rounded-sm bg-mineshaft-600 p-0.5">Ctrl</code> (Windows/Linux) key
and clicking on the secret name.
</div>
}
tooltipClassName="max-w-md"
isError={Boolean(errors?.value)}
errorText={errors?.value?.message}
>