improvements: address greppy

backend/src/ee/routes/v2/secret-scanning-v2-routers/secret-scanning-v2-router.ts

@@ -242,7 +242,7 @@ export const registerSecretScanningV2Router = async (server: FastifyZodProvider)
       tags: [ApiDocsTags.SecretScanning],
       description: "Update the specified Secret Scanning Configuration.",
       querystring: z.object({
-        projectId: z.string().trim().min(1, "Finding ID required").describe(SecretScanningConfigs.UPDATE.projectId)
+        projectId: z.string().trim().min(1, "Project ID required").describe(SecretScanningConfigs.UPDATE.projectId)
       }),
       body: z.object({
         content: z.string().nullable().describe(SecretScanningConfigs.UPDATE.content)

backend/src/ee/services/secret-scanning-v2/github/github-secret-scanning-factory.ts

@@ -1,6 +1,5 @@
 import { join } from "path";
 import { ProbotOctokit } from "probot";
-import RE2 from "re2";
 
 import { scanContentAndGetFindings } from "@app/ee/services/secret-scanning/secret-scanning-queue/secret-scanning-fns";
 import { SecretMatch } from "@app/ee/services/secret-scanning/secret-scanning-queue/secret-scanning-queue-types";
@@ -25,12 +24,11 @@ import {
 import { getConfig } from "@app/lib/config/env";
 import { BadRequestError } from "@app/lib/errors";
 import { titleCaseToCamelCase } from "@app/lib/fn";
+import { GitHubRepositoryRegex } from "@app/lib/regex";
 import { listGitHubRadarRepositories, TGitHubRadarConnection } from "@app/services/app-connection/github-radar";
 
 import { TGitHubDataSourceWithConnection, TQueueGitHubResourceDiffScan } from "./github-secret-scanning-types";
 
-const GitHubRepositoryRegex = new RE2(/^[a-zA-Z0-9._-]+\/[a-zA-Z0-9._-]+$/);
-
 export const GitHubSecretScanningFactory = () => {
   const initialize: TSecretScanningFactoryInitialize<TGitHubRadarConnection> = async (
     { connection, secretScanningV2DAL },

backend/src/ee/services/secret-scanning-v2/github/github-secret-scanning-schemas.ts

@@ -12,11 +12,12 @@ import {
   GitRepositoryScanFindingDetailsSchema
 } from "@app/ee/services/secret-scanning-v2/secret-scanning-v2-schemas";
 import { SecretScanningDataSources } from "@app/lib/api-docs";
+import { GitHubRepositoryRegex } from "@app/lib/regex";
 import { AppConnection } from "@app/services/app-connection/app-connection-enums";
 
 export const GitHubDataSourceConfigSchema = z.object({
   includeRepos: z
-    .array(z.string().min(1).max(256))
+    .array(z.string().regex(GitHubRepositoryRegex, "Invalid repository name format").min(1).max(256))
     .nonempty("One or more repositories required")
     .max(25)
     .default(["*"])

backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-service.ts

@@ -827,6 +827,7 @@ export const secretScanningV2ServiceFactory = ({
         const configPath = join(tempFolder, "infisical-scan.toml");
         await writeTextToFile(configPath, content);
 
+        // just checking if config parses
         await scanContentAndGetFindings("", configPath);
       } catch (e) {
         throw new BadRequestError({

backend/src/lib/regex/index.ts

@@ -9,3 +9,5 @@ export const DistinguishedNameRegex =
 export const UserPrincipalNameRegex = new RE2(/^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9._-]+\.[a-zA-Z]{2,}$/);
 
 export const LdapUrlRegex = new RE2(/^ldaps?:\/\//);
+
+export const GitHubRepositoryRegex = new RE2(/^[a-zA-Z0-9._-]+\/[a-zA-Z0-9._-]+$/);

backend/src/services/app-connection/app-connection-fns.ts

@@ -195,7 +195,6 @@ export const validateAppConnectionCredentials = async (
 export const getAppConnectionMethodName = (method: TAppConnection["method"]) => {
   switch (method) {
     case GitHubConnectionMethod.App:
-      return "GitHub App";
     case GitHubRadarConnectionMethod.App:
       return "GitHub App";
     case AzureKeyVaultConnectionMethod.OAuth: